Skip to content

STM32: Improve GPIO IRQ edge detection when waking from deepsleep #7510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2018
Merged

STM32: Improve GPIO IRQ edge detection when waking from deepsleep #7510

merged 1 commit into from
Jul 23, 2018

Conversation

mattbrown015
Copy link
Contributor

Description

Resolves STM32L4: Incorrect GPIO Interrupts When Using MBED_TICKLESS #7493

After defining MBED_TICKLESS my InterruptIn fall handler stopped being called.

It appears that handle_interrupt_in was incorrectly deciding that a rising edge had caused the IRQ and was attempting the to call the non-existent rise handler. Hence I missed the IRQ.

This problem is something to do with transition from deepsleep, aka stop mode 2, and didn't occur when MBED_TICKLESS was undefined.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

Copy link
Contributor

@LMESTM LMESTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !

@LMESTM
Copy link
Contributor

LMESTM commented Jul 13, 2018

@mattbrown015 thanks for your contribution !
Needs to be tested to check it works well on all families of STM32.
@jeromecoutant should be able to help next week :-)

@jeromecoutant
Copy link
Collaborator

@jeromecoutant should be able to help next week :-)

It has been done during the week end !

I ran tests over all STM32 families => OK
CI shield tests also with all families => OK

Copy link
Contributor

@bcostm bcostm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 17, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 17, 2018

Build : FAILURE

Build number : 2623
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7510/

@jeromecoutant
Copy link
Collaborator

Hi
I understoood the build issue, patch is on going

@jeromecoutant
Copy link
Collaborator

Hi
Please merge #7539 before this one.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 20, 2018

Please merge #7539 before this one.

Merged. @mattbrown015 Can you rebase from latest master to get the dependency in

@jeromecoutant
Copy link
Collaborator

Can you rebase from latest master

I don't think some rebase is needed

/morph build

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 20, 2018

I don't think some rebase is needed

OK. It was not clear how it depends on the other pull request.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 20, 2018

Please review logs http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7510/ - failures in linking - functions definitions are missing?

@jeromecoutant
Copy link
Collaborator

Yes, the correct include has been added in #7539

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 20, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 20, 2018

Build : SUCCESS

Build number : 2653
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7510/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 20, 2018

@mbed-ci
Copy link

mbed-ci commented Jul 20, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 23, 2018

/morph mbed2-build

@cmonr cmonr merged commit 21dbbc5 into ARMmbed:master Jul 23, 2018
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
…deepsleep

STM32: Improve GPIO IRQ edge detection when waking from deepsleep
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants