-
Notifications
You must be signed in to change notification settings - Fork 3k
STM32: Improve GPIO IRQ edge detection when waking from deepsleep #7510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STM32: Improve GPIO IRQ edge detection when waking from deepsleep #7510
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me !
@mattbrown015 thanks for your contribution ! |
It has been done during the week end ! I ran tests over all STM32 families => OK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix
/morph build |
Build : FAILUREBuild number : 2623 |
Hi |
Hi |
Merged. @mattbrown015 Can you rebase from latest master to get the dependency in |
I don't think some rebase is needed /morph build |
OK. It was not clear how it depends on the other pull request. |
Please review logs http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7510/ - failures in linking - functions definitions are missing? |
Yes, the correct include has been added in #7539 |
/morph build |
Build : SUCCESSBuild number : 2653 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2286 |
Test : SUCCESSBuild number : 2395 |
/morph mbed2-build |
…deepsleep STM32: Improve GPIO IRQ edge detection when waking from deepsleep
Description
Resolves STM32L4: Incorrect GPIO Interrupts When Using MBED_TICKLESS #7493
After defining
MBED_TICKLESS
myInterruptIn
fall handler stopped being called.It appears that
handle_interrupt_in
was incorrectly deciding that a rising edge had caused the IRQ and was attempting the to call the non-existent rise handler. Hence I missed the IRQ.This problem is something to do with transition from deepsleep, aka stop mode 2, and didn't occur when
MBED_TICKLESS
was undefined.Pull request type