-
Notifications
You must be signed in to change notification settings - Fork 3k
Add bootloader configuration parameters for MAX32625PICO #7523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/morph build |
Build : SUCCESSBuild number : 2620 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 2261 |
Test : SUCCESSBuild number : 2369 |
@khariya Can you review exporters failure? It's related to device packs. I believe it is related to this change |
I found same error when Maxim pack was not installed, keil_without_pack.txt No error after installing the Maxim pack: keil_with_pack.txt I believe the device name is valid. Would you mind checking if the pack is installed correctly? |
Will get the pack installed in our CI, and rerun once it's good to go. |
IOTTESTINF-3041 |
/morph export-build |
/morph export-build |
1 similar comment
/morph export-build |
/morph mbed2-build |
/morph export-build |
Exporter Build : FAILUREBuild number : 2314 |
The failure in the last exporter looks like the device pack still not present, we will investigate |
Going to re-run, just in case: /morph export-build |
/morph export-build |
2 similar comments
/morph export-build |
/morph export-build |
Exporter Build : FAILUREBuild number : 2349 |
We're reviewing the pack files to see if something is broken. |
@khariya Thanks for looking into the issue. We're also looking to reproduce the issue locally on our side as well. Could you confirm that http://www.mxim.net/microcontroller/pack/Maxim.MAX32650.1.1.0-a.pack is the correct pack that we should be installing? |
@cmonr Here's the pack for MAX32625: http://www.mxim.net/microcontroller/pack/Maxim.MAX32625.1.0.0.pack Your link is for the MAX32650 target. |
Needs work on our end. Still waiting on the CI update. |
An update for MAX32625 pack has been released: It fixed the problem on my local machine. Keil version 5.25.2.0 |
Pack should now be installed. Restarting with build since last build is older than a week. |
Sorry, absolutely no idea what happened there. |
Build : SUCCESSBuild number : 2773 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2402 |
Exporter Build : SUCCESSBuild number : 2404 |
Test : SUCCESSBuild number : 2503 |
Looks like some of the files in this commit have been renamed and then edited in the same commit. This causes problems for 'git am' and makes it extremely difficult to patch. @khariya please try not to do this in the future. Moving this to 5.10 |
@ARMmbed/mbed-os-maintainers |
@adbridge is there a way to check this locally before creating the PR? |
@khariya I'm not sure how you could check it. It looks like the recommended way of doing things is 'git mv' for renaming files, you could try this in the future ? |
@khariya It helps if file move commits are seperate from file changes. If they are together, then the patch application process becomes incredibly sensitive to the order of operations (file change then move, vs file move then changed) and I don't know what the process defaults to. |
Add bootloader configuration parameters for MAX32625PICO
Description
Tested with MAX32625PICO in bootloader mode (default).
Tested override using mbed_app.json for non-bootloader mode.
Pull request type