Skip to content

RTOS SYSTIMER test error in TICKLESS mode #7530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2018

Conversation

jeromecoutant
Copy link
Collaborator

Description

If we enable MBED_TICKLESS, we got a compilation error:

    [DEBUG] Output: ".\TESTS\mbedmicro-rtos-mbed\systimer\main.cpp", line 16: Error:  #29: expected an expression

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@jeromecoutant jeromecoutant changed the title RTOS SYSTIMER test error RTOS SYSTIMER test error in TICKLESS mode Jul 17, 2018
@0xc0170 0xc0170 requested a review from fkjagodzinski July 17, 2018 13:25
Copy link
Member

@fkjagodzinski fkjagodzinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide more info in the commit message. Is this specific to one compiler, if so which one? I checked with GCC_ARM and this patch does not change anything.

@jeromecoutant
Copy link
Collaborator Author

Hi

If we add "MBED_TICKLESS" in the macro in targets.json file,
there is no compilation issue!

If we add "MBED_TICKLESS" in the macro in mbed_app.json file,
we got the compilation issues with all compilers:

  • mbed test -t ARM -m NUCLEO_F429ZI -v -n tests-*systimer --compile
    [DEBUG] Output: ".\TESTS\mbedmicro-rtos-mbed\systimer\main.cpp", line 16: Error: Network is not supported by GCC_ARM toolchain #29: expected an expression

  • mbed test -t GCC_ARM -m NUCLEO_F429ZI -v -n tests-*systimer --compile
    [DEBUG] Output: .\TESTS\mbedmicro-rtos-mbed\systimer\main.cpp:16:19: error: operator '!' has no right operand
    [DEBUG] Output: #if !MBED_TICKLESS

  • mbed test -t IAR -m NUCLEO_F429ZI -v -n tests-*systimer --compile
    [DEBUG] Output: #if !MBED_TICKLESS
    [DEBUG] Output: "C:\github\mbed\TESTS\mbedmicro-rtos-mbed\systimer\main.cpp",16 Error[Pe029]: expected an expression

@fkjagodzinski
Copy link
Member

@jeromecoutant thanks for clarification, I did not check mbed_app.json. I still suggest updating the commit message though. RTOS SYSTIMER test error is ambiguous.

Issue occurs when "MBED_TICKLESS" is added in mbed_app.json,
not when "MBED_TICKLESS" is added in targets.json
@cmonr
Copy link
Contributor

cmonr commented Jul 19, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 19, 2018

Build : SUCCESS

Build number : 2647
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7530/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 19, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 20, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Jul 20, 2018

@cmonr cmonr merged commit a252e5e into ARMmbed:master Jul 23, 2018
@jeromecoutant jeromecoutant deleted the PR_RTOS_TICKLESS branch August 6, 2018 09:17
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
RTOS SYSTIMER test error in TICKLESS mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants