Skip to content

Fix for Thread::max_stack not returning right value when OS_STACK_WATERMARK is enabled #7545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2018
Merged

Fix for Thread::max_stack not returning right value when OS_STACK_WATERMARK is enabled #7545

merged 1 commit into from
Jul 31, 2018

Conversation

SenRamakri
Copy link
Contributor

@SenRamakri SenRamakri commented Jul 18, 2018 •
edited
Loading

Description

The Thread::max_stack function should check for both osRtxStackMagicWord and osRtxStackFillPattern when determining max stack usage. Otherwise it will always return stack_size-4 when OS_STACK_WATERMARK is enabled because RTX fills the top of stack with osRtxStackMagicWord and rest with osRtxStackFillPattern.
Also this change avoids hardcoding osRtxStackMagicWord and osRtxStackFillPattern values.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@SenRamakri SenRamakri requested review from 0xc0170 and c1728p9 July 18, 2018 20:10
@SenRamakri SenRamakri mentioned this pull request Jul 18, 2018
Closed
@0xc0170 0xc0170 requested a review from a team July 20, 2018 14:50
@SenRamakri SenRamakri requested review from kegilbert and deepikabhavnani and removed request for a team July 25, 2018 20:06
@cmonr
Copy link
Contributor

cmonr commented Jul 31, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 31, 2018

Build : SUCCESS

Build number : 2694
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7545/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 31, 2018

Exporter Build : SUCCESS

Build number : 2324
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7545/

@mbed-ci
Copy link

mbed-ci commented Jul 31, 2018

Test : SUCCESS

Build number : 2425
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7545/2425

@cmonr cmonr merged commit b8a2a46 into ARMmbed:master Jul 31, 2018
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Merge pull request ARMmbed#7545 from SenRamakri/sen_StackMaxStackIssue
0c78416 
Fix for Thread::max_stack not returning right value when OS_STACK_WATERMARK is enabled
@0xc0170 0xc0170 mentioned this pull request Jun 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@deepikabhavnani deepikabhavnani deepikabhavnani approved these changes

Assignees
No one assigned
Labels
release-version: 5.9.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SenRamakri @cmonr @mbed-ci @0xc0170 @deepikabhavnani