Fix some targets fail to pass ticker overflow test #7548
Merged
+24
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In mbed-os-tests-mbed_hal-common_tickers/Microsecond ticker overflow test, some targets would fail to catch specified ticker value near overflow in time and so fail. This commit alleviates the issue by checking ticker value range rather than one exact ticker value near overflow.
mprse
approved these changes
Jul 19, 2018
0xc0170
approved these changes
Jul 19, 2018
|
/morph build |
| #define LP_TICKER_OVERFLOW_DELTA1 0 // this will allow to detect that ticker counter rollovers to 0 | ||
| #define LP_TICKER_OVERFLOW_DELTA2 0 | ||
| #define US_TICKER_OVERFLOW_DELTA1 50 | ||
| #define US_TICKER_OVERFLOW_DELTA2 60 |
There was a problem hiding this comment.
It will be good to name the defines as min/max instead 1/2 to have better understanding
There was a problem hiding this comment.
@deepikabhavnani Because this PR has merged, I would make no modification for it.
Build : SUCCESSBuild number : 2645 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2278 |
Test : SUCCESSBuild number : 2384 |
pan-
pushed a commit
to pan-/mbed
that referenced
this pull request
Aug 22, 2018
…verflow Fix some targets fail to pass ticker overflow test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
mbed-os-tests-mbed_hal-common_tickers/Microsecond ticker overflow test, some targets would fail to catch specified ticker value near overflow in time and so fail. This commit alleviates the issue by checking ticker value range rather than one exact ticker value near overflow.Pull request type
@deepikabhavnani