Revise heap and stack size for Ethernet of GR-PEACH #7549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomoYamanaka
force-pushed
the
improve_ether
branch
from
315f778 to
709af11
Compare
0xc0170
reviewed
Jul 19, 2018
features/lwipstack/mbed_lib.json
Outdated
| "default-thread-stacksize": 640, | ||
| "ppp-thread-stacksize": 896, | ||
| "mem-size": 51200 | ||
| } |
There was a problem hiding this comment.
Can you align this same as line 130 or 127
I changed stack size because the deafult stack size may not be enough for Ethernet of GR-PEACH(Cortex-A). - Stack size is default size + 128 byte In order to maximize the performance of Ethernet, I changed heap size to below. - Heap size is default size * 32 byte(send descriptor num is 16 and recv descriptoer num is 16).
TomoYamanaka
force-pushed
the
improve_ether
branch
from
709af11 to
f272472
Compare
|
I aligned line 136. Make a sense? |
0xc0170
approved these changes
Jul 20, 2018
|
@0xc0170 |
We are waiting for ipcore approval (review) |
SeppoTakalo
approved these changes
Jul 24, 2018
|
/morph build |
Build : SUCCESSBuild number : 2661 Triggering tests/morph test |
Test : SUCCESSBuild number : 2402 |
Exporter Build : SUCCESSBuild number : 2294 |
cmonr
approved these changes
Jul 24, 2018
pan-
pushed a commit
to pan-/mbed
that referenced
this pull request
Aug 22, 2018
Revise heap and stack size for Ethernet of GR-PEACH
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I changed stack size because the deafult stack size may not be enough for Ethernet of GR-PEACH(Cortex-A).
Stack size is default size + 128 byte.
In order to maximize the performance of Ethernet, I changed heap size to below.
Heap size is default size * 32 byte(send descriptor num is 16 and recv descriptoer num is 16).
Pull request type