Skip to content

Enable HAL Flash API on Fast Models MPS2 targets #7554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2018
Merged

Enable HAL Flash API on Fast Models MPS2 targets #7554

merged 1 commit into from
Jul 24, 2018

Conversation

jamesbeyond
Copy link
Contributor

Enable HAL Flash API on Fast Models MPS2 targets

This pull request enable the HAL Flash API on all Fast Models MPS2 targets.
And this enabled the Fast Models MPS2 target to run all flash tests and other flash realted functions, IAP etc.

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[x] Feature
[ ] Breaking change

@jamesbeyond
Copy link
Contributor Author

Here attached the HAL Flash test results for all 3 toolchains

+---------------------+---------------+----------------------+------------------------------+--------+--------+--------+--------------------+
| target              | platform_name | test suite           | test case                    | passed | failed | result | elapsed_time (sec) |
+---------------------+---------------+----------------------+------------------------------+--------+--------+--------+--------------------+
| FVP_MPS2_M3-ARM     | FVP_MPS2_M3   | tests-mbed_hal-flash | Flash - clock and cache test | 1      | 0      | OK     | 0.04               |
| FVP_MPS2_M3-ARM     | FVP_MPS2_M3   | tests-mbed_hal-flash | Flash - erase sector         | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-ARM     | FVP_MPS2_M3   | tests-mbed_hal-flash | Flash - init                 | 1      | 0      | OK     | 0.03               |
| FVP_MPS2_M3-ARM     | FVP_MPS2_M3   | tests-mbed_hal-flash | Flash - mapping alignment    | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-ARM     | FVP_MPS2_M3   | tests-mbed_hal-flash | Flash - program page         | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_hal-flash | Flash - clock and cache test | 1      | 0      | OK     | 0.04               |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_hal-flash | Flash - erase sector         | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_hal-flash | Flash - init                 | 1      | 0      | OK     | 0.02               |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_hal-flash | Flash - mapping alignment    | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_hal-flash | Flash - program page         | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-IAR     | FVP_MPS2_M3   | tests-mbed_hal-flash | Flash - clock and cache test | 1      | 0      | OK     | 0.06               |
| FVP_MPS2_M3-IAR     | FVP_MPS2_M3   | tests-mbed_hal-flash | Flash - erase sector         | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-IAR     | FVP_MPS2_M3   | tests-mbed_hal-flash | Flash - init                 | 1      | 0      | OK     | 0.03               |
| FVP_MPS2_M3-IAR     | FVP_MPS2_M3   | tests-mbed_hal-flash | Flash - mapping alignment    | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-IAR     | FVP_MPS2_M3   | tests-mbed_hal-flash | Flash - program page         | 1      | 0      | OK     | 0.0                |
+---------------------+---------------+----------------------+------------------------------+--------+--------+--------+--------------------+

@jamesbeyond
Copy link
Contributor Author

Here attached the mbed driver FlashIAP test results for all 3 toolchains

+----------------------+---------------+-----------------------------+-----------------------------------+--------+--------+--------+--------------------+
| target               | platform_name | test suite                  | test case                         | passed | failed | result | elapsed_time (sec) |
+----------------------+---------------+-----------------------------+-----------------------------------+--------+--------+--------+--------------------+
| FVP_MPS2_M0P-ARM     | FVP_MPS2_M0P  | tests-mbed_drivers-flashiap | FlashIAP - init                   | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M0P-ARM     | FVP_MPS2_M0P  | tests-mbed_drivers-flashiap | FlashIAP - program                | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M0P-ARM     | FVP_MPS2_M0P  | tests-mbed_drivers-flashiap | FlashIAP - program across sectors | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M0P-ARM     | FVP_MPS2_M0P  | tests-mbed_drivers-flashiap | FlashIAP - program errors         | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M0P-GCC_ARM | FVP_MPS2_M0P  | tests-mbed_drivers-flashiap | FlashIAP - init                   | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M0P-GCC_ARM | FVP_MPS2_M0P  | tests-mbed_drivers-flashiap | FlashIAP - program                | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M0P-GCC_ARM | FVP_MPS2_M0P  | tests-mbed_drivers-flashiap | FlashIAP - program across sectors | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M0P-GCC_ARM | FVP_MPS2_M0P  | tests-mbed_drivers-flashiap | FlashIAP - program errors         | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M0P-IAR     | FVP_MPS2_M0P  | tests-mbed_drivers-flashiap | FlashIAP - init                   | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M0P-IAR     | FVP_MPS2_M0P  | tests-mbed_drivers-flashiap | FlashIAP - program                | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M0P-IAR     | FVP_MPS2_M0P  | tests-mbed_drivers-flashiap | FlashIAP - program across sectors | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M0P-IAR     | FVP_MPS2_M0P  | tests-mbed_drivers-flashiap | FlashIAP - program errors         | 1      | 0      | OK     | 0.0                |
+----------------------+---------------+-----------------------------+-----------------------------------+--------+--------+--------+--------------------+

@cmonr cmonr requested review from a team and 0xc0170 July 19, 2018 15:32
fkjagodzinski
fkjagodzinski approved these changes Jul 23, 2018
View reviewed changes
Copy link
Member

@fkjagodzinski fkjagodzinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment below.

targets/TARGET_ARM_FM/TARGET_FVP_MPS2/memory_zones.h
* GCC_ARM).
*
* WARNING: IAR does not include this file and re-define these values in
* MPS2.icf file. Please make sure that the two files share the same values.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this PR also update this file then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this file will be updated. but not in this PR. I do have another PR is going on about refactoring MPS2 board memory layout files. IAR does not use this memory_zone.h anyway, It is should be no impact.

mprse
mprse approved these changes Jul 24, 2018
View reviewed changes
Copy link
Contributor

@mprse mprse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 24, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 24, 2018

Build : SUCCESS

Build number : 2659
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7554/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 24, 2018

Exporter Build : SUCCESS

Build number : 2293
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7554/

@mbed-ci
Copy link

mbed-ci commented Jul 24, 2018

Test : SUCCESS

Build number : 2401
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7554/2401

@cmonr cmonr merged commit e4108b5 into ARMmbed:master Jul 24, 2018
@jamesbeyond jamesbeyond deleted the fm_flash branch July 24, 2018 17:37
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Merge pull request ARMmbed#7554 from jamesbeyond/fm_flash
a60ffee 
Enable HAL Flash API on Fast Models MPS2 targets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@fkjagodzinski fkjagodzinski fkjagodzinski approved these changes

@mprse mprse mprse approved these changes

Assignees
No one assigned
Labels
release-version: 5.9.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jamesbeyond @0xc0170 @mbed-ci @cmonr @fkjagodzinski @mprse