Skip to content

Cellular: Make ATHandler::cmd_start() virtual #7564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2018
Merged

Cellular: Make ATHandler::cmd_start() virtual #7564

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fda096b
Make ATHandler:cmd_start() virtual
Jul 20, 2018
dfc8ca9
made destructor virtual as class has a virtual method now
Aug 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions features/cellular/framework/AT/ATHandler.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ class ATHandler {
* @param send_delay the minimum delay in ms between the end of last response and the beginning of a new command
*/
ATHandler(FileHandle *fh, events::EventQueue &queue, int timeout, const char *output_delimiter, uint16_t send_delay = 0);
~ATHandler();
virtual ~ATHandler();

/** Return used file handle.
*
Expand Down Expand Up @@ -226,7 +226,7 @@ class ATHandler {
*
* @param cmd AT command to be written to modem
*/
void cmd_start(const char *cmd);
virtual void cmd_start(const char *cmd);

/** Writes integer type AT command subparameter. Starts with the delimiter if not the first param after cmd_start.
* In case of failure when writing, the last error is set to NSAPI_ERROR_DEVICE_ERROR.
Expand Down