Skip to content

Nuvoton: Fix NUC472 SD-Host HW IP reset definition #7565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 31, 2018
Merged

Nuvoton: Fix NUC472 SD-Host HW IP reset definition #7565

merged 3 commits into from
Jul 31, 2018

Conversation

cyliangtw
Copy link
Contributor

Description

This PR could fix the wrong definition of NUC472 SD-Host HW IP reset. The wrong definition will encounter EMAC reset as while call SD_Init().

Pull request type

[V] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

Test

Verified OK by cloud client v1.3.3

@0xc0170 0xc0170 requested a review from a team July 20, 2018 12:39
@0xc0170 0xc0170 changed the title Nuvoton: Fixed NUC472 SD-Host HW IP reset definition Nuvoton: Fix NUC472 SD-Host HW IP reset definition Jul 25, 2018
@cyliangtw
Copy link
Contributor Author

It's just only the chip specific HW IP reset wrong definition issue, not relative to mbed-os-core change manner. So, it seems not need to include all mbed-os-ipcore reviewers.
@0xc0170
@samchuarm

@SeppoTakalo
Copy link
Contributor

@mikaleppanen Please review

mikaleppanen
mikaleppanen reviewed Jul 30, 2018
View reviewed changes
Copy link

@mikaleppanen mikaleppanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result should be initialized, otherwise ok.

features/netsocket/emac-drivers/TARGET_NUVOTON_EMAC/numaker_emac.cpp Outdated
@@ -222,15 +222,17 @@ bool NUMAKER_EMAC::link_out(emac_mem_buf_t *buf)
{
bool result;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not changed in this pull request, but noticed that this is left uninitialized on error cases. Should be set false here or on goto to error jumps.

@cyliangtw
Copy link
Contributor Author

@mikaleppanen , thanks of your advisement and it's fixed in commit 2fcbcf1

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 31, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 31, 2018

Build : SUCCESS

Build number : 2700
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7565/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 31, 2018

Exporter Build : SUCCESS

Build number : 2329
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7565/

@mbed-ci
Copy link

mbed-ci commented Jul 31, 2018

Test : SUCCESS

Build number : 2431
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7565/2431

@cmonr cmonr merged commit 63f6216 into ARMmbed:master Jul 31, 2018
@coisme coisme mentioned this pull request Aug 1, 2018
Closed
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Merge pull request ARMmbed#7565 from OpenNuvoton/nuc472_emac_rst
d3b1027 
Nuvoton: Fix NUC472 SD-Host HW IP reset definition
@cyliangtw cyliangtw deleted the nuc472_emac_rst branch September 23, 2019 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@mikaleppanen mikaleppanen mikaleppanen approved these changes

Assignees
No one assigned
Labels
release-version: 5.9.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cyliangtw @SeppoTakalo @0xc0170 @mbed-ci @mikaleppanen @cmonr