Skip to content

Implement qspi_free function #7581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2018
Merged

Implement qspi_free function #7581

merged 1 commit into from
Jul 24, 2018

Conversation

adustm
Copy link
Member

@adustm adustm commented Jul 23, 2018

Description

qspi_free function is now implemented.
It reset QSPI hw block, it reset pins to their initial state, it clears the qspi object memory.

The PR has been validated on DISCO_L475VG_IOT01A with mbed_hal/qspi test (init free test is still passing).

+-----------------------------+---------------------+---------------------+-------------------------------------------------------+--------+--------+--------+--------------------+
| target                      | platform_name       | test suite          | test case                                             | passed | failed | result | elapsed_time (sec) |
+-----------------------------+---------------------+---------------------+-------------------------------------------------------+--------+--------+--------+--------------------+
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi frequency setting test                           | 1      | 0      | OK     | 0.39               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi init/free test                                   | 1      | 0      | OK     | 0.21               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi memory id test                                   | 1      | 0      | OK     | 0.1                |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-1-1)/x1  read(1-1-1)/x1  repeat/x1  test | 1      | 0      | OK     | 0.14               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-1-1)/x1  read(1-1-1)/x1  repeat/x16 test | 1      | 0      | OK     | 0.78               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-1-1)/x1  read(1-1-1)/x4  repeat/x1  test | 1      | 0      | OK     | 0.14               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-1-1)/x1  read(1-1-2)/x1  repeat/x1  test | 1      | 0      | OK     | 0.14               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-1-1)/x1  read(1-1-2)/x1  repeat/x16 test | 1      | 0      | OK     | 0.78               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-1-1)/x1  read(1-1-2)/x4  repeat/x1  test | 1      | 0      | OK     | 0.15               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-1-1)/x1  read(1-1-4)/x1  repeat/x1  test | 1      | 0      | OK     | 0.16               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-1-1)/x1  read(1-1-4)/x1  repeat/x16 test | 1      | 0      | OK     | 0.79               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-1-1)/x1  read(1-1-4)/x4  repeat/x1  test | 1      | 0      | OK     | 0.15               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-1-1)/x1  read(1-2-2)/x1  repeat/x1  test | 1      | 0      | OK     | 0.14               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-1-1)/x1  read(1-2-2)/x1  repeat/x16 test | 1      | 0      | OK     | 0.78               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-1-1)/x1  read(1-2-2)/x4  repeat/x1  test | 1      | 0      | OK     | 0.15               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-1-1)/x1  read(1-4-4)/x1  repeat/x1  test | 1      | 0      | OK     | 0.15               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-1-1)/x1  read(1-4-4)/x1  repeat/x16 test | 1      | 0      | OK     | 0.78               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-1-1)/x1  read(1-4-4)/x4  repeat/x1  test | 1      | 0      | OK     | 0.15               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-1-1)/x4  read(1-1-1)/x1  repeat/x1  test | 1      | 0      | OK     | 0.15               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-1-1)/x4  read(1-1-2)/x1  repeat/x1  test | 1      | 0      | OK     | 0.15               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-1-1)/x4  read(1-1-4)/x1  repeat/x1  test | 1      | 0      | OK     | 0.15               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-1-1)/x4  read(1-2-2)/x1  repeat/x1  test | 1      | 0      | OK     | 0.15               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-1-1)/x4  read(1-4-4)/x1  repeat/x1  test | 1      | 0      | OK     | 0.15               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-4-4)/x1  read(1-1-1)/x1  repeat/x1  test | 1      | 0      | OK     | 0.15               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-4-4)/x1  read(1-1-1)/x1  repeat/x16 test | 1      | 0      | OK     | 0.82               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-4-4)/x1  read(1-1-1)/x4  repeat/x1  test | 1      | 0      | OK     | 0.14               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-4-4)/x1  read(1-1-2)/x1  repeat/x1  test | 1      | 0      | OK     | 0.16               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-4-4)/x1  read(1-1-2)/x1  repeat/x16 test | 1      | 0      | OK     | 0.82               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-4-4)/x1  read(1-1-2)/x4  repeat/x1  test | 1      | 0      | OK     | 0.15               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-4-4)/x1  read(1-1-4)/x1  repeat/x1  test | 1      | 0      | OK     | 0.15               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-4-4)/x1  read(1-1-4)/x1  repeat/x16 test | 1      | 0      | OK     | 0.82               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-4-4)/x1  read(1-1-4)/x4  repeat/x1  test | 1      | 0      | OK     | 0.15               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-4-4)/x1  read(1-2-2)/x1  repeat/x1  test | 1      | 0      | OK     | 0.15               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-4-4)/x1  read(1-2-2)/x1  repeat/x16 test | 1      | 0      | OK     | 0.82               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-4-4)/x1  read(1-2-2)/x4  repeat/x1  test | 1      | 0      | OK     | 0.15               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-4-4)/x1  read(1-4-4)/x1  repeat/x1  test | 1      | 0      | OK     | 0.15               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-4-4)/x1  read(1-4-4)/x1  repeat/x16 test | 1      | 0      | OK     | 0.81               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-4-4)/x1  read(1-4-4)/x4  repeat/x1  test | 1      | 0      | OK     | 0.15               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-4-4)/x4  read(1-1-1)/x1  repeat/x1  test | 1      | 0      | OK     | 0.17               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-4-4)/x4  read(1-1-2)/x1  repeat/x1  test | 1      | 0      | OK     | 0.16               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-4-4)/x4  read(1-1-4)/x1  repeat/x1  test | 1      | 0      | OK     | 0.16               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-4-4)/x4  read(1-2-2)/x1  repeat/x1  test | 1      | 0      | OK     | 0.16               |
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | qspi write(1-4-4)/x4  read(1-4-4)/x1  repeat/x1  test | 1      | 0      | OK     | 0.16               |
+-----------------------------+---------------------+---------------------+-------------------------------------------------------+--------+--------+--------+--------------------+

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@cmonr cmonr requested a review from maciejbocianski July 23, 2018 15:11
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 24, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 24, 2018

Build : SUCCESS

Build number : 2658
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7581/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@maciejbocianski maciejbocianski mentioned this pull request Jul 24, 2018
Merged
@mbed-ci
Copy link

mbed-ci commented Jul 24, 2018

Exporter Build : SUCCESS

Build number : 2292
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7581/

@mbed-ci
Copy link

mbed-ci commented Jul 24, 2018

Test : SUCCESS

Build number : 2400
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7581/2400

@0xc0170 0xc0170 merged commit 488baf9 into ARMmbed:feature-qspi Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@maciejbocianski maciejbocianski maciejbocianski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adustm @0xc0170 @mbed-ci @maciejbocianski @cmonr