Remove unnecessary low power ticker rescheduling #7600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wait until dispatching is finished before scheduling the next ticker interrupt. This prevents unnecissary calls to set_interrupt from periodic elements being added back. This is particularly useful for the low power ticker on devices with LPTICKER_DELAY_TICKS set to a non-zero value. This is because the low power ticker cannot be reschduled immediately and needs to fall back onto the microsecond ticker which temporarily locks deep sleep.
Schedule the next OS tick inside of the ticker interrupt rather than in the systick interrupt. Scheduling this while the ticker is dispatching prevents an unnecissary rescheduling since this rescheduling is done anyway when dispatching is finished. This is particularly useful for the low power ticker on devices with LPTICKER_DELAY_TICKS set to a non-zero value. This is because the low power ticker cannot be reschduled immediately and needs to fall back onto the microsecond ticker which temporarily locks deep sleep. Note - the optimization in this commit is made possible by the commit: "Don't reschedule ticker while dispatching"
0xc0170
approved these changes
Jul 26, 2018
cmonr
approved these changes
Aug 14, 2018
|
@pan- @kjbracey-arm Mind taking a look? /morph build |
Build : SUCCESSBuild number : 2788 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2418 |
|
CI issue last night. Restarting. /morph test |
Test : FAILUREBuild number : 2529 |
|
Unclear whether CI failure is caused by PR or CI load. |
Test : SUCCESSBuild number : 2554 |
pan-
pushed a commit
to pan-/mbed
that referenced
this pull request
Aug 22, 2018
…ower_ticker_rescheduling Remove unnecessary low power ticker rescheduling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is an optimization to prevent the tickers, particularly the low power ticker, from being rescheduled unnecessarily.
Pull request type