Skip to content

Tools: Correct win_to_unix path handling #7608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2018
Merged

Conversation

theotherjimmy
Copy link
Contributor

Description

After #7183, many problems cropped up WRT exporters handling of include
paths. This was related to my naive use of os.sep. After calling
win_to_unix, the seperator for the resources object is forced to /.
This PR makes that behaivor explicit by keeping the seperator around.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from cmonr July 26, 2018 15:28
@cmonr
Copy link
Contributor

cmonr commented Jul 26, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 26, 2018

Build : SUCCESS

Build number : 2677
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7608/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 26, 2018

@mbed-ci
Copy link

mbed-ci commented Jul 26, 2018

@cmonr cmonr merged commit 639285a into ARMmbed:master Jul 26, 2018
@0xc0170 0xc0170 removed the needs: CI label Jul 26, 2018
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Tools: Correct `win_to_unix` path handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants