cellular: astyle fix #7621
cellular: astyle fix #7621
Conversation
| @@ -398,18 +398,18 @@ bool ATCmdParser::process_oob() | |||
| struct oob *oob = _oobs; | |||
| while (oob) { | |||
| if (i == (int)oob->len && memcmp( | |||
| oob->prefix, _buffer, oob->len) == 0) { | |||
| oob->prefix, _buffer, oob->len) == 0) { | |||
There was a problem hiding this comment.
This could fit on the same line like
if (i == (int)oob->len && memcmp(oob->prefix, _buffer, oob->len) == 0) {
| @@ -20,15 +20,13 @@ | |||
|
|
|||
| TEST_GROUP(AT_CellularBase) | |||
There was a problem hiding this comment.
For being consistent with function expansion, please change, void setup() { to:
void setup()
{
}
as it was originally. Martin will be patching astyle script to ignore expanding functions in the pre-processed objects like TEST_GROUP.
There was a problem hiding this comment.
Good catch, I'll check these macros and will need to be ignored not to be changed as they are not seen by formatter (is it a function/class/etc) so its treated as function by default.
Ignore TEST_GROUP by AStyle. As this uses macro, is not visible to formatter.
By default, it assumes it is a function and treats methods as blocks inside a
function (inlined {}). We ignore it.
We might just not format UNITTESTS in the future if we face similar issues
in the future.
|
All |
|
/morph build |
Build : SUCCESSBuild number : 2709 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2338 |
Test : SUCCESSBuild number : 2440 |
|
@ARMmbed/mbed-os-maintainers Please review |
cellular: astyle fix
Description
Running astyle for cellular feature. I run it on all files in the folder. If there are any that should be excludeed, let me know, and I'll add it to the astyle ignore file.
Pull request type