-
Notifications
You must be signed in to change notification settings - Fork 3k
Tools: Omit include path parents when they're scan rules #7623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
by 0.45% for Mbed Cloud Client
@deepikabhavnani @cmonr This is not as good as I hoped. All well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting.
/morph build |
Build : SUCCESSBuild number : 2711 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 2340 |
Test : SUCCESSBuild number : 2442 |
@studavekar @ARMmbed/mbed-os-test Are y'all able to confirm that the SPIF lib is being setup correctly? Unsure if this is a PR, examples.py, or CI config issue. |
Looks like it was a GitHub issue https://mbed-os.mbedcloudtesting.com/job/build_wrapper/5352/console
|
/morph export-build |
Exporter Build : SUCCESSBuild number : 2352 |
Relies on #7183 which is scheduled for 5.10 |
Tools: Omit include path parents when they're scan rules
Description
Realistically, people don't do the following:
instead, they do this:
Knowing this, I remove collecting of include paths "through label
directories". Label directories are the things we scan for when building.
They start with
TARGET_
,TOOLCHAIN_
andFEATURE_
. This PR collectsinclude path parents up to the first label dir.
I think an example is in order. Here is the Mbed OS targets directory:
Notice how there is no header file in the
targets
directory. When weadd include paths for the K64F, we would all parents of
targets/TARGET_Freescale/mbed_rtx.h
. Which would be:That's overkill. Instead this PR reduces this example to the following
include paths:
While this may seem great, you would be hard pressed to measure this
improvement. It reduce the include paths by an entire 0.5% on MCC by
my measurements (20346, with this change; 20439 without).
Pull request type