-
Notifications
You must be signed in to change notification settings - Fork 3k
Removing unused rt_OsEventObserver #7635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
462c9c3
to
90202d2
Compare
As stated, not used, thus no dependency on uvisor removal that is currently pending ? |
@0xc0170 - Yes, this doesn't depend on uvisor removal. May be this was added for some debugging purposes. So, can be removed. |
@SenRamakri - Got reference of EventObserver from old docs (not sure if still valid) https://docs.mbed.com/docs/mbed-os-handbook/en/latest/advanced/cmsis-rtos/ |
@deepikabhavnani - Thanks for pointing that out. I'm looking into that, its still not clear if/how its used. |
@SenRamakri - As per https://github.com/ARMmbed/mbed-os/blob/master/tools/importer/cmsis_importer.json, below mentioned PR's are related to uVisior change and is pulled in everytime we do CMSIS update.
On approval of this PR, all the commits reverted should be removed from |
@deepikabhavnani - Thanks for finding the above commits. I'm waiting on @alzix to review this so that we can confirm if we can revert all of them. |
please note that this PR can only be merged after #7592. |
Thanks @alzix. Updated the PR to more better indicate this. In the meantime, @bulislaw @alzix @deepikabhavnani would y'all mind taking a look at this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for removing that.
As per https://github.com/ARMmbed/mbed-os/blob/master/tools/importer/cmsis_importer.json, below mentioned PR's are related to uVisior change and is pulled in everytime we do CMSIS update. adb6e82 All the above commits reverted should be removed from cmsis_importer.json as well, else we will have them back in next CMSIS update. I would recommend to add a revert PR to above commits, instead of code change |
@SenRamakri Thoughts on deepikabhavnani suggestion on instead applying |
This PR will not be needed after CMSIS update #7875 |
Closing as not needed anymore |
Description
This removes rt_OsEventObserver from RTX. It was added as part of uvisor and is not used and we already have RTX event mechanism to track any thread related events. This will save around 150 bytes, and this also helps remove unwanted code adding to CPU cycles on every thread switch.
Pull request type