LoRaWAN: Fixing incorrect NetID causing ABP Failures #7641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kivaisan
approved these changes
Jul 30, 2018
kivaisan
suggested changes
Jul 30, 2018
hasnainvirk
force-pushed
the
abp_armc6_fix
branch
from
83322eb to
4293b8b
Compare
The issue rose up when using ARMC6. A test case didn't initialize NetID parameter for ABP while using connect(params) API. NetID is the first 7 bits of the Device Address. It makes sense to actually remove the net-id parameter from ABP settings as the stack can deduce it from device address. However, the ABP structure is exposed in public APIs, so we can't really do that at the moment. Simpler fix is to move the mask that helps us to extract first 7 bits of the device address is exposed in lorawan_types.h and the user can use it to deduce correct net-id.
hasnainvirk
force-pushed
the
abp_armc6_fix
branch
from
4293b8b to
31aaea6
Compare
0xc0170
approved these changes
Jul 30, 2018
|
/morph build |
Build : SUCCESSBuild number : 2696 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2326 |
Test : SUCCESSBuild number : 2427 |
pan-
pushed a commit
to pan-/mbed
that referenced
this pull request
Aug 22, 2018
LoRaWAN: Fixing incorrect NetID causing ABP Failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The issue rose up when using ARMC6. A test case didn't initialize NetID
parameter for ABP while using connect(params) API. NetID is the first 7 bits
of the Device Address. It makes sense to actually remove the net-id parameter
from ABP settings as the stack can deduce it from device address. However, the ABP
structure is exposed in public APIs, so we can't really do that at the moment.
Simpler fix is to move the mask that helps us to extract first 7 bits of the device address
is exposed in lorawan_types.h and the user can use it to deduce correct net-id.
Pull request type