nrf_drv_twi: remove redundant nrf_drv_disable call in nrf_drv_twi_uninit #7645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i2c_api implementation for NRF52 does a disable() followed by uninit(). The uniinit() implementation in NRF drivers layer makes another call to disable. This throws off the state of the I2C instance leading to an assert. Since the disable is only invoked from the I2C API layer for Nordic, remove this redundant call. Signed-off-by: Naveen Kaje <[email protected]>
|
Fixes #7425 |
cmonr
approved these changes
Aug 14, 2018
|
/morph build |
Build : SUCCESSBuild number : 2794 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2424 |
|
/morph test |
Test : SUCCESSBuild number : 2538 |
pan-
pushed a commit
to pan-/mbed
that referenced
this pull request
Aug 22, 2018
nrf_drv_twi: remove redundant nrf_drv_disable call in nrf_drv_twi_uninit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I2C API implementation for NRF5x does a disable() followed by uninit().
The uninit() implementation in NRF drivers layer makes another call to
disable(). This throws off the state of the I2C instance leading to an
assert. Since the disable is only invoked from the I2C API layer for
Nordic, remove this redundant call.
Signed-off-by: Naveen Kaje [email protected]
Pull request type