-
Notifications
You must be signed in to change notification settings - Fork 3k
Cellular: Add CellularDevice::init_module API to be called at startup #7667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jarvte please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please split functional changes from style changes ( 2 separate commits)
f7558d7
to
c6ab45b
Compare
Split functional changes from style changes in separate commits. @jarvte please re-review |
@0xc0170 please rereview |
@0xc0170 is there something still to do? |
@AriParkkila Nope! Thanks for the split. /morph build |
Build : SUCCESSBuild number : 2793 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2423 |
Test : FAILUREBuild number : 2528 |
@cmonr |
Looks like this has failed due to some networking issues in CI. Suggest we re-run this once the CI is less heavily loaded. |
/morph test |
Test : SUCCESSBuild number : 2566 |
Cellular: Add CellularDevice::init_module API to be called at startup
Description
Added a new API CellularDevice::init_module to initialize cellular module. This function need to be called right after cellular module is ready to make any module specific initialization.
Pull request type