Skip to content

Cellular: Add CellularDevice::init_module API to be called at startup #7667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2018

Conversation

AriParkkila
Copy link

Description

Added a new API CellularDevice::init_module to initialize cellular module. This function need to be called right after cellular module is ready to make any module specific initialization.

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[X] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from a team August 1, 2018 07:43
@AriParkkila
Copy link
Author

@jarvte please review

@0xc0170 0xc0170 changed the title Cellular: Added CellularDevice::init_module API to be called at startup Cellular: Add CellularDevice::init_module API to be called at startup Aug 1, 2018
0xc0170
0xc0170 previously requested changes Aug 1, 2018
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split functional changes from style changes ( 2 separate commits)

@AriParkkila
Copy link
Author

Split functional changes from style changes in separate commits.

@jarvte please re-review

@AriParkkila
Copy link
Author

@0xc0170 please rereview

@AriParkkila
Copy link
Author

@0xc0170 is there something still to do?

@cmonr cmonr dismissed 0xc0170’s stale review August 14, 2018 01:11

Changes addressed.

@cmonr
Copy link
Contributor

cmonr commented Aug 14, 2018

@AriParkkila Nope! Thanks for the split.

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 14, 2018

Build : SUCCESS

Build number : 2793
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7667/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 14, 2018

@mbed-ci
Copy link

mbed-ci commented Aug 14, 2018

@AriParkkila
Copy link
Author

@cmonr ci-morph-test is failing with "mbedgt: no platform/target matching tests were found!". That's unlikely due to this change?

@adbridge
Copy link
Contributor

Looks like this has failed due to some networking issues in CI. Suggest we re-run this once the CI is less heavily loaded.

@cmonr
Copy link
Contributor

cmonr commented Aug 16, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Aug 17, 2018

@cmonr cmonr merged commit 871ee09 into ARMmbed:master Aug 17, 2018
@0xc0170 0xc0170 removed the needs: CI label Aug 17, 2018
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Cellular: Add CellularDevice::init_module API to be called at startup
@AriParkkila AriParkkila deleted the cellular-detect branch September 10, 2018 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants