Renesas : Improve Flash iap #7675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I modified the _page_program() because when the request of the size exceeding the maximum size(256 byte) per one writing of Flash recieved, it was not able to loop the writing with sifting the address every 256 byte. Also I modified the return value of flash_get_page_size() because I found that the minimum size per one writing of Flash is 1 byte by reviewing Flash spec. "FLASH_PAGE_SIZE" macro's value is remain 256, it doesn't be used at flash_get_page_size(), used at _page_program() for refferencing of the maximum page size.
0xc0170
approved these changes
Aug 2, 2018
|
/morph build |
Build : SUCCESSBuild number : 2721 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2357 |
Test : SUCCESSBuild number : 2453 |
pan-
pushed a commit
to pan-/mbed
that referenced
this pull request
Aug 22, 2018
Renesas : Improve Flash iap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I revised flash_iap.c file of Renesas.
I modified the
_page_program()because when request size is over the maximum size(256 byte) per one writing, it was not able to loop the writing every 256 byte.Also I modified the return value of
flash_get_page_size()because the minimum size per one writing was 1 byte by Flash spec.FLASH_PAGE_SIZEmacro is remain 256, it doesn't be used atflash_get_page_size(), used at_page_program()as the maximum page size.Relation Issue
#7649 (comment)
Test result
NVStore and Flash iAP was passed.
Test_PEACH_GCC_NVStore_Flash.txt
Test_LYCHEE_GCC_NVStore_Flash.txt
Pull request type