Skip to content

Nanostack: fix error code #7678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2018
Merged

Nanostack: fix error code #7678

merged 1 commit into from
Aug 7, 2018

Conversation

juhaylinen
Copy link
Contributor

@juhaylinen juhaylinen commented Aug 2, 2018 •
edited
Loading

Description

Return NSAPI_ERROR_NO_MEMORY if socket->open() fails

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from a team August 2, 2018 11:25
@SeppoTakalo
Copy link
Contributor

Please change this to NO_MEMORY error. NO_SOCKET is used when someone uses Socket class without opening it first, or if stack has somehow lost the socket id.

@juhaylinen
Nanostack: fix error code
942b772 
Return NSAPI_ERROR_NO_MEMORY if socket->open() fails
@juhaylinen juhaylinen force-pushed the fix-nanostack-return-code branch from a864a99 to 942b772 Compare August 3, 2018 09:14
@juhaylinen
Copy link
Contributor Author

@SeppoTakalo change done

@juhaylinen
Copy link
Contributor Author

Changes approved. How about starting the CI?

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 7, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 7, 2018

Build : SUCCESS

Build number : 2750
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7678/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 7, 2018

Test : SUCCESS

Build number : 2474
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7678/2474

@mbed-ci
Copy link

mbed-ci commented Aug 7, 2018

Exporter Build : SUCCESS

Build number : 2380
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7678/

@cmonr cmonr merged commit 616e14a into ARMmbed:master Aug 7, 2018
@juhaylinen juhaylinen deleted the fix-nanostack-return-code branch August 8, 2018 12:10
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Merge pull request ARMmbed#7678 from juhaylinen/fix-nanostack-return-…
c82b7f3 
…code

Nanostack: fix error code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

Assignees
No one assigned
Labels
release-version: 5.9.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@juhaylinen @SeppoTakalo @0xc0170 @mbed-ci @cmonr