Skip to content

PR template: fix target update list #7689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2018
Merged

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Aug 3, 2018

Description

Not only new target, any target update goes to own section. This covers
target updates to SDK, HAL implementation, target list, etc.
All these go to patch releases.

what about Feature - this is for features, but also shall cover new functionality (is this clear enough that even adding new function to public API this makes it "feature"?) ?

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Feature
[ ] Breaking change

Not only new target, any target update goes to own section. This covers
target updates to SDK, HAL implementation, target list, etc.
All these go to patch releases.
@0xc0170 0xc0170 requested a review from a team August 3, 2018 09:57
@NirSonnenschein
Copy link
Contributor

@0xc0170 does this need CI? (I've put the label on since it seems to be approved on review, but I'm not sure if this needs an actual CI run)

@0xc0170
Copy link
Contributor Author

0xc0170 commented Aug 6, 2018

@0xc0170 does this need CI? (I've put the label on since it seems to be approved on review, but I'm not sure if this needs an actual CI run)

Yes please. Will start one

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 6, 2018

Build : SUCCESS

Build number : 2735
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7689/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 6, 2018

@mbed-ci
Copy link

mbed-ci commented Aug 6, 2018

@0xc0170
Copy link
Contributor Author

0xc0170 commented Aug 6, 2018

/morph mbed2-build

@cmonr cmonr merged commit 6561a7f into ARMmbed:master Aug 6, 2018
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
PR template: fix target update list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants