python scripts : table print with github policy

[jeromecoutant]

Description

This is following ARMmbed/greentea#277 discussion

Goal is to get test console print compatible with github like :

target	platform_name	test suite	result	elapsed_time (sec)	copy_method
DISCO_L475VG_IOT01A-ARM	DISCO_L475VG_IOT01A	tests-mbed_drivers-lp_ticker	OK	21.31	default
DISCO_L475VG_IOT01A-ARM	DISCO_L475VG_IOT01A	tests-mbed_drivers-lp_timeout	OK	59.35	default

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Feature
[ ] Breaking change

[jeromecoutant]

For information, here is all related PR :

• python scripts : table print with github policy #7720
• Use PrettyTable with GitHub policy greentea#279
• Use PrettyTable with GitHub policy mbed-ls#383
• Use PrettyTable with GitHub policy htrun#208

[cmonr]

Alright, this has simmered for long enough.

I like the change, but I'm not married to it one way or another.

@ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-test @theotherjimmy @bridadan @ARMmbed/device-os-custom-engineering-and-support @ARMmbed/mbed-os-core Any strong feelings one way or another?

Since this is a PR against all of the tools, I'd like it sorted out one way or another sooner rather than later.

[theotherjimmy]

Changes look good. Copy-paste-able tables should have always been a design goal.

[adbridge]

/morph build

[mbed-ci]

Build : SUCCESS

Build number : 2805
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7720/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

[mbed-ci]

Exporter Build : FAILURE

Build number : 2435
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7720/

[cmonr]

/morph export-build

[cmonr]

/morph export-build

[mbed-ci]

Exporter Build : SUCCESS

Build number : 2442
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7720/

[mbed-ci]

Exporter Build : SUCCESS

Build number : 2442
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7720/

[mbed-ci]

Test : FAILURE

Build number : 2534
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7720/2534

[adbridge]

Looks like this has failed due to some networking issues in CI. Suggest we re-run this once the CI is less heavily loaded.

[cmonr]

/morph test

[yennster]

I like it, however the missing top/bottom lines on the compile build size information makes it a bit hard to read compared to the previous implementation (in my opinion):

New	Old

Not a big deal though!

[jeromecoutant]

Maybe, we can add some empty line before and after array ?

[mbed-ci]

Test : SUCCESS

Build number : 2563
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7720/2563

[cmonr]

https://github.com/ozh/ascii-tables So many ascii tables...

@jeromecoutant Could you add whitespace to make the CLI output a bit easier to discern?

[0xc0170]

Maybe, we can add some empty line before and after array ?

👍 Please do

[0xc0170]

@jeromecoutant Let us know once updated.

For information, here is all related PR :

There's list of dependencies. @cmonr @theotherjimmy What should be the order (this goes first and then the rest or?) ?

[cmonr]

@0xc0170 Fortunately it's not a dependency list.

In this case, the Mbed OS tools and Mbed OS changes don't rely on one another. We only need to make sure that the tools and Mbed OS version that is released line up to present the "this is a new feature across our tools" story.

[cmonr]

A different question.

One or two of those PRs has/have now gone in, which is great, but that begs the question of whether we should still add the whitespace change request, or bring this in asis.

For the sake of time, I'd argue for bringing it in asis, since this would be ready for CI.

[cmonr]

@theotherjimmy @OPpuolitaival @bridadan ^^^ Above question.

[jamesbeyond]

Just wonder why not just leave the top and bottom border in? it is more clear in the console output. and not doing any harm if you want to copy the table to markdown file. just don't copy those 2 lines.

[bridadan]

@jamesbeyond I think the idea is you can post the whole log and you get the table for free. If you had to delete lines then it wouldn't work out-of-the-box.

@cmonr Having a new line would be nice, but if there's a big push to get this in it can always be added in another PR. But if this isn't a high priority I don't have a problem with you waiting on it for a bit.

[yennster]

Have we gotten those blank lines?

[cmonr]

Nope, and now that the othre PRs have been merged, it looks like we should omit them to keep all of the tools homogeneous.

Will restart CI when able (we restart CI when past successful results in a PR are older than a week).

[0xc0170]

/morph build

[mbed-ci]

Build : SUCCESS

Build number : 3022
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7720/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

[mbed-ci]

Test : FAILURE

Build number : 2789
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7720/2789

[cmonr]

Test failure not caused by PR. Requeueing.
/morph test

[mbed-ci]

Exporter Build : SUCCESS

Build number : 2637
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7720/

[mbed-ci]

Test : FAILURE

Build number : 2791
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7720/2791

[cmonr]

/morph test

[mbed-ci]

Test : SUCCESS

Build number : 2795
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7720/2795