Skip to content

Fix owner restoration and discard across nvstore init #7721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2018

Conversation

orenc17
Copy link
Contributor

@orenc17 orenc17 commented Aug 7, 2018

Description

NVstore didnt discard owner from offsets before usage with flash API

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Feature
[ ] Breaking change

@ARMmbed/mbed-os-storage for your review

@cmonr cmonr requested a review from a team August 7, 2018 16:00
Copy link
Contributor

@davidsaada davidsaada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. Looks good.

@cmonr
Copy link
Contributor

cmonr commented Aug 8, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 8, 2018

Build : SUCCESS

Build number : 2756
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7721/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 8, 2018

@mbed-ci
Copy link

mbed-ci commented Aug 8, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 8, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Aug 8, 2018

@orenc17
Copy link
Contributor Author

orenc17 commented Aug 8, 2018

could you please run it again, the failure was not related to the PR

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 8, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Aug 8, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 8, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Aug 8, 2018

@cmonr cmonr merged commit 1ab05c2 into ARMmbed:master Aug 8, 2018
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Fix owner restoration and discard across nvstore init
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants