PR template: Feature -> functionality change #7728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature might be misinterpreted in some cases. This label should be about functionality in backward compatible way. That means that this is either deprecating some current one or adding new functionality. Functionality change should cover: - adding configuration - deprecating functionality - adding new functionality This change would go automatically to feature release.
cmonr
approved these changes
Aug 8, 2018
|
Fine with me, but I would suggest holding off until the others get back tomorrow. |
|
@AnotherButler Also please review this |
kjbracey
approved these changes
Aug 8, 2018
AnotherButler
approved these changes
Aug 9, 2018
|
/morph build |
Build : SUCCESSBuild number : 2802 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2432 |
|
/morph test |
Test : FAILUREBuild number : 2533 |
|
/morph test |
Test : SUCCESSBuild number : 2557 |
pan-
pushed a commit
to pan-/mbed
that referenced
this pull request
Aug 22, 2018
PR template: Feature -> functionality change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feature might be misinterpreted in some cases. This label should be about
functionality in backward compatible way. That means that this is either
deprecating some current one or adding new functionality.
Functionality change should cover:
This change would go automatically to feature release.
Pull request type