Skip to content

Timeout tests : unstable result #7738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2018
Merged

Conversation

jeromecoutant
Copy link
Collaborator

Description

lp_timeout test is not 100% OK for all iterations.

RTX waits, such as sem.wait(N+1), delays for between N and N+1 cycles.

As lp_ticker is not so accurate as us_ticker, delay can be also variable around N depending on used clock.

So sometimes, in lp_timeout test, semaphore wait is expiring just before the lp_timeout, and test becomes fail.
Proposition is then to use sem.wait(N+2).
Test result becomes now 100% OK.

Thx

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Feature
[ ] Breaking change

RTX waits, such as sem.wait(N), delays for between N-1 and N cycles.
As lp_ticker is not so accurate as us_ticker,
sometines, wait is expiring just before the lp_timeout.
@0xc0170 0xc0170 requested a review from fkjagodzinski August 9, 2018 08:25
@0xc0170 0xc0170 requested a review from a team August 9, 2018 08:31
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 9, 2018

Copy link
Member

@fkjagodzinski fkjagodzinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeromecoutant, thanks for the fix!

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 10, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 10, 2018

Build : SUCCESS

Build number : 2774
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7738/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 10, 2018

@mbed-ci
Copy link

mbed-ci commented Aug 10, 2018

@cmonr
Copy link
Contributor

cmonr commented Aug 13, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Aug 13, 2018

@cmonr cmonr merged commit 8b47f9e into ARMmbed:master Aug 13, 2018
@0xc0170 0xc0170 removed the needs: CI label Aug 13, 2018
@jeromecoutant jeromecoutant deleted the PR_WAITSEM branch August 14, 2018 06:56
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants