-
Notifications
You must be signed in to change notification settings - Fork 3k
Timeout tests : unstable result #7738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
RTX waits, such as sem.wait(N), delays for between N-1 and N cycles. As lp_ticker is not so accurate as us_ticker, sometines, wait is expiring just before the lp_timeout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeromecoutant, thanks for the fix!
/morph build |
Build : SUCCESSBuild number : 2774 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2405 |
Test : FAILUREBuild number : 2508 |
/morph test |
Test : SUCCESSBuild number : 2513 |
Timeout tests : unstable result
Description
lp_timeout test is not 100% OK for all iterations.
RTX waits, such as sem.wait(N+1), delays for between N and N+1 cycles.
As lp_ticker is not so accurate as us_ticker, delay can be also variable around N depending on used clock.
So sometimes, in lp_timeout test, semaphore wait is expiring just before the lp_timeout, and test becomes fail.
Proposition is then to use sem.wait(N+2).
Test result becomes now 100% OK.
Thx
Pull request type