Skip to content

Update mbed-coap to version 4.6.1 #7739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 22, 2018
Merged

Update mbed-coap to version 4.6.1 #7739

merged 2 commits into from
Aug 22, 2018

Conversation

anttiylitokola
Copy link
Contributor

@anttiylitokola anttiylitokola commented Aug 9, 2018 •
edited
Loading

Description

Added new API which clears one item from the resend queue by token.

Fixes error: IOTCLT-2900 - Blockwise handling leaking memory in some error cases

  • Fix memory leak when clearing blockwise payload list
  • Token was not freed from the list when closing down the library

Fix unused parameter - warning when blockwise is not used

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[X] Feature
[ ] Breaking change

@anttiylitokola
Copy link
Contributor Author

@yogpan01, please review

@0xc0170 0xc0170 requested a review from yogpan01 August 9, 2018 12:00
@yogpan01
Copy link
Contributor

yogpan01 commented Aug 9, 2018

@0xc0170 This is a candidate for next 5.10 release , please take this in to the codebaseline.

@cmonr
Copy link
Contributor

cmonr commented Aug 14, 2018

/morph build

cmonr
cmonr reviewed Aug 14, 2018
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment. Otherwise LGTM.

features/frameworks/mbed-coap/source/sn_coap_protocol.c
}
}
#endif
return -2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it correct that if if the #define is not enabled, this function will always return an error?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because this function handles cases where re-sending of messages is causing internal queue to be full hence there is a methodology to remove those messages. However, if the resending is not enabled then this function will always return error.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to be sure, since the pattern looked strange.

@mbed-ci
Copy link

mbed-ci commented Aug 14, 2018

Build : SUCCESS

Build number : 2798
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7739/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 14, 2018

Exporter Build : SUCCESS

Build number : 2428
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7739/

@cmonr
Copy link
Contributor

cmonr commented Aug 14, 2018

/morph test

Update mbed-coap to version 4.6.0
590dfeb 
* Added new API which clears one item from the resend queue by token
Update mbed-coap to version 4.6.1
f78f560 
Fixes error: IOTCLT-2900 - Blockwise handling leaking memory in some error cases
* Fix memory leak when clearing blockwise payload list
* Token was not freed from the list when closing down the library

Fix unused parameter - warning when blockwise is not used
@anttiylitokola anttiylitokola changed the title Update mbed-coap to version 4.6.0 Update mbed-coap to version 4.6.1 Aug 15, 2018
@anttiylitokola
Copy link
Contributor Author

Bring couple of more fixes in. Description also updated.

@cmonr
Copy link
Contributor

cmonr commented Aug 15, 2018

@yogpan01 Mind taking another look?

@yogpan01
Copy link
Contributor

@cmonr There has been few more fixes related with memory leak in certain blockwise use cases, new update is fixing those. So this is ok from my side.

@cmonr
Copy link
Contributor

cmonr commented Aug 16, 2018

@anttiylitokola Would you mind answering my quiestion? https://github.com/ARMmbed/mbed-os/pull/7739/files#r209809055

@cmonr
Copy link
Contributor

cmonr commented Aug 17, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 17, 2018

Build : SUCCESS

Build number : 2825
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7739/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 17, 2018

Exporter Build : SUCCESS

Build number : 2455
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7739/

@cmonr
Copy link
Contributor

cmonr commented Aug 17, 2018

/morph uvisor-test

@mbed-ci
Copy link

mbed-ci commented Aug 18, 2018

Test : FAILURE

Build number : 2576
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7739/2576

@NirSonnenschein
Copy link
Contributor

/morph uvisor-test

1 similar comment
@NirSonnenschein
Copy link
Contributor

/morph uvisor-test

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 21, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Aug 21, 2018

Test : SUCCESS

Build number : 2603
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7739/2603

@0xc0170 0xc0170 merged commit f5fb3c1 into ARMmbed:master Aug 22, 2018
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
@0xc0170
Merge pull request ARMmbed#7739 from anttiylitokola/master
6d337ed 
Update mbed-coap to version 4.6.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yogpan01 yogpan01 yogpan01 approved these changes

@cmonr cmonr cmonr approved these changes

Assignees
No one assigned
Labels
release-version: 5.10.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@anttiylitokola @yogpan01 @cmonr @mbed-ci @NirSonnenschein @0xc0170