Skip to content

Cellular: Fixed sms greentea tests init #7750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 14, 2018
Merged

Cellular: Fixed sms greentea tests init #7750

merged 2 commits into from
Aug 14, 2018

Conversation

jarvte
Copy link
Contributor

@jarvte jarvte commented Aug 10, 2018 •
edited
Loading

Description

  • Fixed sms greentea tests by making sure that device is ready to accept AT commands before sending them.
  • removed some character set setting to sms as they are not common and not supported by every modem

Internal ref to defect: IOTCELL-1219
Internal ref to defect: IOTCELL-1220

@TeemuKultala please review

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Feature
[ ] Breaking change

@jarvte
Copy link
Contributor Author

jarvte commented Aug 10, 2018

travis failed because of lisence check failed

@jarvte jarvte force-pushed the fix_smsgreentea_tests branch from 573a235 to 7ff26db Compare August 10, 2018 08:34
@0xc0170 0xc0170 requested a review from a team August 10, 2018 08:45
0xc0170
0xc0170 requested changes Aug 10, 2018
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add text from description to the commit message (info about the bugfix)

@jarvte jarvte force-pushed the fix_smsgreentea_tests branch from 7ff26db to e1edd79 Compare August 10, 2018 10:19
@jarvte
Copy link
Contributor Author

jarvte commented Aug 10, 2018

@0xc0170 updated commit message.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 10, 2018

Thanks

Fixed sms greentea tests by making sure that device is ready to accept
AT commands before sending them. Removed some character set setting to
sms as they are not common and not supported by every modem.

These looks like 2 separate fixes , shall be split?

Teppo Järvelin added 2 commits August 10, 2018 13:57
Cellular: Fixed sms greentea tests init
6a64ca9 
Fixed sms greentea tests by making sure that device is ready to accept
AT commands before sending them.
Cellular: Fixed sms greentea by removing uncommon character set setting
a8faeac
@jarvte jarvte force-pushed the fix_smsgreentea_tests branch from e1edd79 to a8faeac Compare August 10, 2018 11:12
@jarvte
Copy link
Contributor Author

jarvte commented Aug 10, 2018

@0xc0170 now it's splitted into two commits.

ghost
ghost reviewed Aug 10, 2018
View reviewed changes
features/cellular/TESTS/api/cellular_sms/main.cpp
// First store current service address
store_service_center_address();

createFSM();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is createFSM call needed here, if it is also called in store_service_center_address?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FSM is also deleted in store_service_center_address so that we can create unique ATHandler as we can't access it from public API's.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 10, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 10, 2018

Build : SUCCESS

Build number : 2777
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7750/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 10, 2018

Test : FAILURE

Build number : 2510
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7750/2510

@mbed-ci
Copy link

mbed-ci commented Aug 10, 2018

Exporter Build : SUCCESS

Build number : 2408
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7750/

@jarvte
Copy link
Contributor Author

jarvte commented Aug 13, 2018

@0xc0170 seem like failures are not related to this PR.

@cmonr
Copy link
Contributor

cmonr commented Aug 13, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Aug 13, 2018

Test : SUCCESS

Build number : 2514
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7750/2514

@cmonr cmonr merged commit 7bdfc07 into ARMmbed:master Aug 14, 2018
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Merge pull request ARMmbed#7750 from jarvte/fix_smsgreentea_tests
995a823 
Cellular: Fixed sms greentea tests init
@jarvte jarvte deleted the fix_smsgreentea_tests branch October 22, 2018 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

Assignees
No one assigned
Labels
release-version: 5.9.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jarvte @0xc0170 @mbed-ci @cmonr @AnttiKauppila