Lora: Fix TX_ERROR event if corrupted msg is received for CONFIRMED request #7767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equest When node sends a CONFIRMED message and gateway sends ACK in RX1 window but the message gets corrupted during the transmission (e.g. MIC fails), currently our stack already checks for retransmission after RX1 and if retries attemps are exhausted, TX_ERROR event is sent to application. This is wrong as MAC layer will still attempt reception in RX2 window. This commit fixes the behaviour so that TX_ERROR is not sent until RX2 window has been closed.
|
@hasnainvirk @AnttiKauppila @kjbracey-arm please review |
|
This is fix for #7718 |
hasnainvirk
approved these changes
Aug 13, 2018
AnttiKauppila
approved these changes
Aug 13, 2018
kjbracey
approved these changes
Aug 16, 2018
|
@cmonr This needs CI. Failure is not related to the PR. |
|
/morph build |
Build : SUCCESSBuild number : 2838 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2466 |
Test : SUCCESSBuild number : 2589 |
|
/morph uvisor-test |
pan-
pushed a commit
to pan-/mbed
that referenced
this pull request
Aug 22, 2018
…er_msg_received Lora: Fix TX_ERROR event if corrupted msg is received for CONFIRMED request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When node sends a CONFIRMED message and gateway sends ACK in RX1 window but the
message gets corrupted during the transmission (e.g. MIC fails), currently
our stack already checks for retransmission after RX1 and if retries attemps are
exhausted, TX_ERROR event is sent to application. This is wrong as MAC layer
will still attempt reception in RX2 window.
This commit fixes the behaviour so that TX_ERROR is not sent until RX2 window
has been closed.
Pull request type