Skip to content

Modified Jenkinsfile into one-liner format. #7772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2018
Merged

Modified Jenkinsfile into one-liner format. #7772

merged 2 commits into from
Aug 22, 2018

Conversation

timurh01
Copy link
Contributor

Description

@OPpuolitaival
Jenkinsfile refactoring into one-liner format in order to use improved internal Jenkins scripting.

Pull request type

[ ] Fix
[ x ] Refactor
[ ] Target update
[ ] Feature
[ ] Breaking change

@OPpuolitaival
Copy link
Contributor

Looks good

@cmonr cmonr self-requested a review August 13, 2018 14:40
@cmonr cmonr requested a review from studavekar August 13, 2018 14:40
@cmonr
Copy link
Contributor

cmonr commented Aug 13, 2018

@ARMmbed/mbed-os-test I've been wondering. What does this file do, and where is it used?

What does mbed.run_job() call, and is it in the Mbed OS repo, or somewhere else?

@timurh01
Copy link
Contributor Author

Mbed-OS Jenkins CI runs command from Jenkinsfile, and that triggers Jenkins test jobs to run. Jenkins is used to run tests that cannot be shared publicly. Script framework, that is called by this mbed.run_job(), is located in repo mbed-os-ci/vars (private repo). And this frame is already built that way, that old format Jenkinsfile is actually calling mbed.run_job() command.
More info from @OPpuolitaival

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we are doing this update, as @cmonr asked about it. Can we add a description to this file what it does, why it is here.

// This is internal file for internal jenkins (something similar)

@OPpuolitaival
Copy link
Contributor

@0xc0170 good point

@timurh01
Copy link
Contributor Author

Comment inside Jenkinsfile updated.

@cmonr
Copy link
Contributor

cmonr commented Aug 21, 2018

/morph build

@OPpuolitaival
Copy link
Contributor

@cmonr morph build need to retriggering. There was jenkins internal failure

@mbed-ci
Copy link

mbed-ci commented Aug 21, 2018

Build : SUCCESS

Build number : 2851
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7772/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 21, 2018

@mbed-ci
Copy link

mbed-ci commented Aug 22, 2018

@0xc0170 0xc0170 merged commit b373b13 into ARMmbed:master Aug 22, 2018
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Modified Jenkinsfile into one-liner format.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants