Skip to content

Lora: Fix join-response failure handling #7785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2018
Merged

Lora: Fix join-response failure handling #7785

merged 1 commit into from
Aug 22, 2018

Conversation

kivaisan
Copy link
Contributor

Description

Thix commit fixes a bug where stack was resending join-accept already
after RX1 if received join-response was invalid.

Stack should wait for RX2 before resending the join-accept.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Feature
[ ] Breaking change

Thix commit fixes a bug where stack was resending join-accept already
after RX1 if received join-response was invalid.

Stack should wait for RX2 before resending the join-accept.
@kivaisan
Copy link
Contributor Author

@hasnainvirk @AnttiKauppila @kjbracey-arm please review.

@hasnainvirk
Copy link
Contributor

Looks good to me. +1

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 20, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 20, 2018

Build : SUCCESS

Build number : 2839
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7785/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 20, 2018

@mbed-ci
Copy link

mbed-ci commented Aug 20, 2018

@kivaisan
Copy link
Contributor Author

Could you please restart the test as I don't see this failure is related to this PR?

@NirSonnenschein
Copy link
Contributor

/morph test
/morph uvisor-test

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 21, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Aug 21, 2018

@0xc0170 0xc0170 merged commit 81f5dec into ARMmbed:master Aug 22, 2018
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
…_handling

Lora: Fix join-response failure handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants