Skip to content

Moved ASYNCHRONOUS_DNS_SIMULTANEOUS_REPEAT under mbed extended tests #7786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2018
Merged

Moved ASYNCHRONOUS_DNS_SIMULTANEOUS_REPEAT under mbed extended tests #7786

merged 1 commit into from
Aug 16, 2018

Conversation

mikaleppanen
Copy link

Description

Test is giving problems in some networks. Could be that DNS server is regarding repeated DNS enquiries on the test to be caused by malfunctioning device.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Feature
[ ] Breaking change

Test is giving problems in some networks. Could be that DNS server
is regarding repeated DNS enquiries on the test to be caused by
malfunctioning device.
Copy link
Contributor

@adbridge adbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we know that the asynchronous DNS tests will now be run? When are MBED_EXTENDED_TESTS actually run ?

@adbridge adbridge requested a review from cmonr August 14, 2018 11:40
@mikaleppanen
Copy link
Author

@adbridge Tests flagged with MBED_EXTENDED_TESTS are build/run once a day against latest mbed-os master in the ip-core Jenkins build system.

Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick response!

@cmonr
Copy link
Contributor

cmonr commented Aug 14, 2018

@adbridge Looks like there are some other tests already in the repo that use this compiler flag.

@cmonr
Copy link
Contributor

cmonr commented Aug 14, 2018

/morph build

@adbridge
Copy link
Contributor

@mikaleppanen So have we just effectively removed some testing from pull requests ? ie we won't now be able to detect issues with asynch dns until after a PR has been merged to master potentially ?

@mikaleppanen
Copy link
Author

@adbridge The other asynchronous DNS tests will verify most of the functionality. So I think it is not problem if this particular test is not run for all pull requests.

@mbed-ci
Copy link

mbed-ci commented Aug 14, 2018

Build : SUCCESS

Build number : 2809
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7786/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 14, 2018

@mbed-ci
Copy link

mbed-ci commented Aug 16, 2018

@cmonr
Copy link
Contributor

cmonr commented Aug 16, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Aug 16, 2018

@cmonr cmonr merged commit 3c25b96 into ARMmbed:master Aug 16, 2018
@mikaleppanen mikaleppanen deleted the dns_repeat_to_ext branch August 17, 2018 06:27
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Moved ASYNCHRONOUS_DNS_SIMULTANEOUS_REPEAT under mbed extended tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants