-
Notifications
You must be signed in to change notification settings - Fork 3k
STM32 LPTICKER : RTC wake up timer is reset before setting a new one #7790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- decreased to 1 for low freq targets - removed for high freq targets - not changed for targets with LPTIM
@@ -270,7 +270,7 @@ void rtc_write(time_t t) | |||
|
|||
#if DEVICE_LPTICKER && !MBED_CONF_TARGET_LPTICKER_LPTIM | |||
/* Need to update LP_continuous_time value before new RTC time */ | |||
uint32_t current_lp_time = rtc_read_lp(); | |||
rtc_read_lp(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be nice to (void) the return of this function to show that you are purposefully ignoring the return value ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this very specific case, we don't need to get the return value.
Function is called because global variable LP_continuous_time is updated there.
/morph build |
Build : SUCCESSBuild number : 2841 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 2469 |
Test : FAILUREBuild number : 2592 |
/morph test |
Exporter Build : SUCCESSBuild number : 2477 |
Test : SUCCESSBuild number : 2606 |
STM32 LPTICKER : RTC wake up timer is reset before setting a new one
Description
Affected targets : targets supporting LPTICKER and using RTC wake up timer.
Patch:
NB:
@c1728p9 @LMESTM
Tests
Patch tested with ARM tool chain with 1 board per STM32 family
Tests with TICKLESS look OK with NUCLEO_F401RE
Pull request type