Template specialization didnt work after addition of default constructor

[deepikabhavnani]

Description

Template specialization didn't work after addition of default constructor for unsupported polynomials. Since the argument type and count are same, compiler always selects the default constructor.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Feature
[ ] Breaking change

[deepikabhavnani]

@geky - Verified in build, only polynomial used is linked.

Size with 32-bit ANSI CRC
| mbed-os\drivers\TableCRC.o | 64 | 0 | 0 |

Size with 16-bit CRC
| mbed-os\drivers\TableCRC.o | 512 | 0 | 0 |

[cmonr]

@deepikabhavnani Does the size increase with the 16-bit CRC? What is the 512 value?

[deepikabhavnani]

Default size of CRC table is 256 elements and each element equivalent to size of polynomial. Hence for 16-bit CRC it is 256*2.

32-bit polynomial table was optimised recently and it is 16 * 4 byte long.

[geky]

Looks good to me 👍

Thanks for testing if the tables got optimized out

[cmonr]

Will start CI once load has gone down.

[cmonr]

/morph build

[mbed-ci]

Build : SUCCESS

Build number : 2827
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7793/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

[cmonr]

/morph uvisor-test

[mbed-ci]

Exporter Build : FAILURE

Build number : 2457
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7793/

[cmonr]

Weird. It looks like it didn't even try to build certain targets.

Going to see if this was a fluke.
/morph export-build

[mbed-ci]

Exporter Build : SUCCESS

Build number : 2460
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7793/

[mbed-ci]

Test : SUCCESS

Build number : 2578
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7793/2578

[deepikabhavnani]

/morph uvisor-test

[0xc0170]

@deepikabhavnani Known issue with uvisor CI, we are investigating

[NirSonnenschein]

/morph uvisor-test

[deepikabhavnani]

Hello.. CRC PR's #7735, #7781, #7793 and #7824 are related and will be better to have them all in one patch. Can we change the tag of merged PR's to next patch