LoRaWAN: Custom FSB selection in US and Australian regions #7802

hasnainvirk · 2018-08-16T10:02:54Z

Description

We have introduced an Mbed config based method to configure a custom frequency sub-band in US915 and AU915 PHYs. US915Hybrid PHY is removed as it was an attempt to make a similar effort. It only allowed one sub-band as it was hard coded. Now user can choose any set of sub-band or sub-bands.

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Feature
[ ] Breaking change

hasnainvirk · 2018-08-16T10:04:32Z

@AnttiKauppila @kivaisan @kjbracey-arm Please review.

kivaisan

Looks ok.

hasnainvirk · 2018-08-20T11:44:41Z

@kjbracey-arm Please review.

kjbracey

Seems fine, just still unclear on the difference in mask handling between the two channel types.

kjbracey · 2018-08-20T13:18:29Z

features/lorawan/lorastack/phy/LoRaPHYAU915.cpp

@@ -580,6 +578,8 @@ lorawan_status_t LoRaPHYAU915::set_next_channel(channel_selection_params_t* next
        if ((current_channel_mask[4] & 0x00FF) == 0) {
            // fall back to 500 kHz default channels
            current_channel_mask[4] = channel_mask[4];
+        } else {
+            current_channel_mask[4] &= channel_mask[4];


Why this addition, which doesn't mirror the code for 125kHz channels above? Is it because of the lack of &= in link_ADR_request? (I recall previous discussion of that, but don't remember the explanation, and there's no comment in the code).

hasnainvirk · 2018-08-21T07:50:30Z

@kjbracey-arm Please review again. Suggestions entertained.

johanstokking

Looks good to me, two comments;

I think it would be good to clarify that this library targets PHY 1.0.2 rev B
I would recommend writing in the documentation to use the FSB mask only on private networks where you know beforehand what FSB is being used and/or in case of ABP. With OTAA, certainly on public networks, it's highly recommended to use the channel probing strategy as defined in PHY

johanstokking · 2018-08-21T08:06:57Z

features/lorawan/FSB_Usage.txt

@@ -0,0 +1,35 @@
+Frequency sub-bands in US915/US915Hybrid/AU915:
+
+ US915/US915Hybrid/AU915 PHYs define channel structures which can support up-to 72 channels for upstream.


US915Hybrid is gone now

hasnainvirk · 2018-08-22T05:03:26Z

@cmonr need CI here again. Breakage doesn't relate to this PR.

hasnainvirk · 2018-08-22T05:03:42Z

@kjbracey-arm Please review.

cmonr · 2018-08-22T05:12:42Z

@hasnainvirk Thanks for the poke. Thought I had gotten them all earlier today.

hasnainvirk · 2018-08-22T13:19:40Z

@kjbracey-arm Can you please review ?

0xc0170 · 2018-08-22T15:10:45Z

/morph build

mbed-ci · 2018-08-22T17:13:14Z

Build : FAILURE

Build number : 2868
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7802/

cmonr · 2018-08-23T03:22:03Z

Build issue is known. Will relaunch once corrected.

cmonr · 2018-08-23T04:26:06Z

/morph build

cmonr · 2018-08-23T04:29:22Z

Weird.
/morph build

hasnainvirk · 2018-08-23T11:22:47Z

@cmonr @0xc0170 Exporter build failed for some reason. Can you please check ?

0xc0170 · 2018-08-23T11:24:06Z

Pipeline locked error, restarting

/morph export-build

mbed-ci · 2018-08-23T13:41:59Z

Exporter Build : FAILURE

Build number : 2500
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7802/

cmonr · 2018-08-23T17:15:50Z

Pausing Test CI until 5.9.6 PR is merged.
Will restart CI shortly after.

cmonr · 2018-08-24T05:56:46Z

/morph test

cmonr · 2018-08-24T06:01:24Z

/morph export-build

mbed-ci · 2018-08-24T08:30:55Z

Exporter Build : SUCCESS

Build number : 2511
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7802/

0xc0170 · 2018-08-24T08:53:21Z

This needs rebase ! I am aborting the test run, will restart

User can now define a custom frequency sub-band for the US915 PHY. FSB_Usage.txt defines how this parameter will be configured.

Just like US915 PHY, user can define a custom FSB mask for AU915 PHY. This helps deployments where base stations do not portray full feature channel sets and choose to stick with sub-bands.

This phy implementation was just to support a single sub-band in US region. As we have decided to make FSBs configurable, we do not need this class anymore.

A few protected member functions are introduced in LoRaPHY class that help manipulate channel masks in various ways.

hasnainvirk · 2018-08-24T12:58:26Z

@0xc0170 Rebased and locally tested once more.

0xc0170 · 2018-08-24T13:14:36Z

/morph build

mbed-ci · 2018-08-24T17:05:35Z

Build : SUCCESS

Build number : 2897
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7802/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-08-24T20:00:49Z

Exporter Build : FAILURE

Build number : 2522
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7802/

cmonr · 2018-08-25T00:00:15Z

Pipes be closin to soon...

/morph export-build

mbed-ci · 2018-08-25T01:31:38Z

Exporter Build : SUCCESS

Build number : 2527
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7802/

mbed-ci · 2018-08-25T08:46:11Z

Test : SUCCESS

Build number : 2648
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7802/2648

AnttiKauppila · 2018-08-27T06:33:27Z

@0xc0170 This can be merged

kivaisan approved these changes Aug 16, 2018

View reviewed changes

hasnainvirk mentioned this pull request Aug 16, 2018

LoRaWAN: Fixing Hard fault in CN470 PHY layer #7806

Merged

hasnainvirk force-pushed the pipeline_br branch from ad0d382 to 15be906 Compare August 16, 2018 13:32

cmonr added release-version: 5.10.0-rc1 needs: review labels Aug 16, 2018

cmonr self-requested a review August 16, 2018 14:25

AnttiKauppila approved these changes Aug 17, 2018

View reviewed changes

cmonr requested a review from kjbracey August 17, 2018 15:25

hasnainvirk changed the title ~~Custom FSB selection in US and Australian regions~~ LoRaWAN: Custom FSB selection in US and Australian regions Aug 20, 2018

kjbracey reviewed Aug 20, 2018

View reviewed changes

hasnainvirk force-pushed the pipeline_br branch from 15be906 to 6502f22 Compare August 21, 2018 07:49

johanstokking reviewed Aug 21, 2018

View reviewed changes

hasnainvirk force-pushed the pipeline_br branch 3 times, most recently from b367c3c to f4aec91 Compare August 21, 2018 14:44

kjbracey approved these changes Aug 22, 2018

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Aug 22, 2018

0xc0170 added needs: work and removed needs: CI labels Aug 24, 2018

Hasnain Virk added 4 commits August 24, 2018 15:31

Adding FSB selection feature for US915 PHY

207ae2d

User can now define a custom frequency sub-band for the US915 PHY. FSB_Usage.txt defines how this parameter will be configured.

Enabling FSB support in AU915 PHY

dc56a06

Just like US915 PHY, user can define a custom FSB mask for AU915 PHY. This helps deployments where base stations do not portray full feature channel sets and choose to stick with sub-bands.

Removing US915Hybrid PHY

8f0bb07

This phy implementation was just to support a single sub-band in US region. As we have decided to make FSBs configurable, we do not need this class anymore.

Adding helpers for Channel mask manipulation

9b2507d

A few protected member functions are introduced in LoRaPHY class that help manipulate channel masks in various ways.

hasnainvirk force-pushed the pipeline_br branch from f4aec91 to 9b2507d Compare August 24, 2018 12:57

0xc0170 added needs: CI and removed needs: work labels Aug 24, 2018

cmonr added ready for merge and removed needs: CI labels Aug 25, 2018

0xc0170 merged commit b4d5e24 into ARMmbed:master Aug 27, 2018

0xc0170 removed the ready for merge label Aug 27, 2018

		@@ -0,0 +1,35 @@
		Frequency sub-bands in US915/US915Hybrid/AU915:

		US915/US915Hybrid/AU915 PHYs define channel structures which can support up-to 72 channels for upstream.

LoRaWAN: Custom FSB selection in US and Australian regions #7802

LoRaWAN: Custom FSB selection in US and Australian regions #7802

Uh oh!

Conversation

hasnainvirk commented Aug 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Uh oh!

hasnainvirk commented Aug 16, 2018

Uh oh!

kivaisan left a comment

Choose a reason for hiding this comment

Uh oh!

hasnainvirk commented Aug 20, 2018

Uh oh!

kjbracey left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hasnainvirk commented Aug 21, 2018

Uh oh!

johanstokking left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hasnainvirk commented Aug 22, 2018

Uh oh!

hasnainvirk commented Aug 22, 2018

Uh oh!

cmonr commented Aug 22, 2018

Uh oh!

hasnainvirk commented Aug 22, 2018

Uh oh!

0xc0170 commented Aug 22, 2018

Uh oh!

mbed-ci commented Aug 22, 2018

Uh oh!

cmonr commented Aug 23, 2018

Uh oh!

cmonr commented Aug 23, 2018

Uh oh!

cmonr commented Aug 23, 2018

Uh oh!

hasnainvirk commented Aug 23, 2018

Uh oh!

0xc0170 commented Aug 23, 2018

Uh oh!

mbed-ci commented Aug 23, 2018

Uh oh!

cmonr commented Aug 23, 2018

Uh oh!

cmonr commented Aug 24, 2018

Uh oh!

cmonr commented Aug 24, 2018

Uh oh!

mbed-ci commented Aug 24, 2018

Uh oh!

0xc0170 commented Aug 24, 2018

Uh oh!

hasnainvirk commented Aug 24, 2018

Uh oh!

0xc0170 commented Aug 24, 2018

Uh oh!

mbed-ci commented Aug 24, 2018

Triggering tests

Uh oh!

mbed-ci commented Aug 24, 2018

Uh oh!

cmonr commented Aug 25, 2018

Uh oh!

mbed-ci commented Aug 25, 2018

Uh oh!

mbed-ci commented Aug 25, 2018

Uh oh!

AnttiKauppila commented Aug 27, 2018

Uh oh!

Uh oh!

hasnainvirk commented Aug 16, 2018 •

edited

Loading