Skip to content

Add Socket test plan #7803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 10, 2018
Merged

Add Socket test plan #7803

merged 2 commits into from
Sep 10, 2018

Conversation

SeppoTakalo
Copy link
Contributor

@SeppoTakalo SeppoTakalo commented Aug 16, 2018 •
edited by cmonr
Loading

Description

I'm submitting a test plan for Mbed OS sockets, so that we have
reference that describes wanted behaviour, required test environment,
and priorities of test cases.

This serves as a both documentation and specification. It needs to live
with source code, as opposed to Handbook, because it will be extended, modified
and fixed for faster cycle than what should be done for the Handbook.

Part of this document (How to run -section) will be submitted to Handbook
with links to this documentation.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[X] Feature
[ ] Breaking change

@SeppoTakalo
Copy link
Contributor Author

@AnotherButler Please review sections from start, to "Running tests".
No reason to review the testcases, it might be a bit painful, and is not meant to be read, only referred as a specification.

@SeppoTakalo
Copy link
Contributor Author

@kjbracey-arm please review.

Add Socket test plan
0bb791e 
I'm submitting a test plan for Mbed OS sockets, so that we have
reference that describes wanted behaviour, required test environment,
and priorities of test cases.

This servers as a both documentation and specification. It needs to live
with source code, as opposed to Handbook, because it will be extend, modified
and fixed for faster cycle than what should be done for Handbook.

Part of this document (How to run -section) will be submitted to Handbook
with links to this.
@0xc0170 0xc0170 requested a review from a team August 22, 2018 12:48
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 22, 2018

Adding @ARMmbed/mbed-os-test (as this is a test plan, I believe our first one here? )

@0xc0170 0xc0170 requested a review from bulislaw August 22, 2018 12:49
@cmonr cmonr added the risk: G label Aug 23, 2018
@cmonr cmonr requested a review from a team August 25, 2018 00:33
@cmonr cmonr removed the risk: G label Aug 25, 2018
Copy edit requested section of README.md
940c4b8 
Copy edit for active voice, inclusion of articles and U.S. spelling.
OPpuolitaival
OPpuolitaival approved these changes Aug 29, 2018
View reviewed changes
Copy link
Contributor

@OPpuolitaival OPpuolitaival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@SeppoTakalo
Copy link
Contributor Author

@0xc0170 Why does this need CI?
It is just a .md file.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 31, 2018

Our workflow states PR needs to be green (CI status here as "Required"). We do not currently have subset of tests or what shall be run based on the changes in the PR. We shall discuss this how we can improve this (now that more docs are coming to the repository - test plans, design documents, etc) for 5.11

@cmonr
Copy link
Contributor

cmonr commented Sep 7, 2018

Marking for rc2 for now to make sure we don't lose track of it.

@cmonr
Copy link
Contributor

cmonr commented Sep 8, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 8, 2018

Build : SUCCESS

Build number : 3036
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7803/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 8, 2018

Test : SUCCESS

Build number : 2809
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7803/2809

@mbed-ci
Copy link

mbed-ci commented Sep 8, 2018

Exporter Build : SUCCESS

Build number : 2652
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7803/

@cmonr cmonr merged commit 920db63 into ARMmbed:master Sep 10, 2018
@0xc0170 0xc0170 removed the needs: CI label Sep 10, 2018
@SeppoTakalo SeppoTakalo deleted the socket-test-plan branch September 12, 2018 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OPpuolitaival OPpuolitaival OPpuolitaival approved these changes

@kjbracey kjbracey kjbracey approved these changes

@AnotherButler AnotherButler AnotherButler approved these changes

@bulislaw bulislaw Awaiting requested review from bulislaw

Assignees
No one assigned
Labels
release-version: 5.10.0-rc2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@SeppoTakalo @0xc0170 @cmonr @mbed-ci @OPpuolitaival @kjbracey @AnotherButler