-
Notifications
You must be signed in to change notification settings - Fork 3k
Connectivity drivers #7814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connectivity drivers #7814
Conversation
@kjbracey-arm please review |
Hi Seppo Can I ask why wifi-ism43362 is not imported as well ? Thx |
Hi @jeromecoutant for the first round I'm importing only the ones that we are actively maintaining and testing in our CI. This is part of the change where I submitted PR earlier into most of the connectivity drivers, ISM as well in ARMmbed/wifi-ism43362#27 Now going forward, applications can be made portable by just choosing which one to provide the default interface. Driver being outside of Mbed OS tree does not make any difference, once the configuration is in place. |
@cmonr What is the justification for "Needs work" label? |
As this is adding components, doesn't this depend on components tools changes or is it good as it is? |
@0xc0170 This does not depend on the component support, even that the folder name is the same. These drivers have been tested not to affect RAM or ROM usage, as long as they are unused. So there is no need to exclude from the build. |
e039912
to
3519487
Compare
Rebased on top of master. |
@SeppoTakalo I would normally say to check the failure logs, but 1) the job artifacts have been garbage collected by Jenkins due to the history length, and 2) I'm not sure how to retrigger a build. @ARMmbed/mbed-os-test Some help? |
This is dependent on #7778 which should go in first |
Client test is known to fail, because it is testing with previous release. |
@SeppoTakalo @0xc0170 Keep in mind that @bulislaw is on vacation for the rest of the month.
I think it was because the cloud_client_smoke_test check was failing. Still talking with @ARMmbed/mbed-os-test to see how to restart the test. |
Now waiting on @kjbracey-arm and the predeeding PR. |
3519487
to
1db096f
Compare
Rebased on top of master. |
Build : FAILUREBuild number : 2981 |
I derp'd and used origin/master instead of upstream/master. Doing the rebase again. |
This device still requires MCR20A driver to be in build tree and this patch PelionIoT/mcr20a-rf-driver#18
These boards do not fit the full Nanostack, so we need to select 6LoWPAN-ND as a default.
Some targets have SDA and SCL defined in public headers, breaking the build of AT24MAC driver.
This needs proper implementation later.
Testing a mesh requires proper environment.
0370d1f
to
0456085
Compare
/morph build |
Build : SUCCESSBuild number : 2982 Triggering tests/morph test |
Test : SUCCESSBuild number : 2739 |
Exporter Build : SUCCESSBuild number : 2590 |
@@ -321,6 +321,13 @@ __asm static void delay_loop(uint32_t count) | |||
BCS %BT1 | |||
BX lr | |||
} | |||
#elif defined (__ARMCC_VERSION) /* ARMC6 */ | |||
void delay_loop(uint32_t count) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In which world this doesn't get optimized out (ref) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does, I just needed a placeholder to get it building with ARMC6.
Other compilers already have assembly version provided, but none of those builded OK with ARMC6
Should this be in a COMPONENT_ESP8266 directory? |
Description
Import connectivity drivers into Mbed OS.
After this change, any of those driver can be selected as a default driver. This allows building connectivity examples for applications without connectivity.
This allows us to migrate away from easy-connect dependency.
Documentation how default network interfaces work, please see:
This PR depends on #7778
Pull request type