Skip to content

Allow ThreadInterface::device_eui64_get() before connect() #7818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2018

Conversation

kjbracey
Copy link
Contributor

@kjbracey kjbracey commented Aug 17, 2018

Description

Perform necessary driver initialisation so that we can read the EUI-64 before connecting.

Fixes #7391.

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

Marked as refactor as it's a non-trivial initialisation rework, and it wasn't necessarily intended to permit this ordering originally, although it makes sense.

Can unify quite a log of the setup here, and that would be useful to
allow initialisation other than in "connect".
Perform necessary driver initialisation so that we can read
the EUI-64 before connecting.

Fixes ARMmbed#7391.
@kjbracey kjbracey changed the title Eui64 get early Allow ThreadInterface::device_eui64_get() before connect() Aug 17, 2018
@kjbracey kjbracey requested a review from artokin August 21, 2018 08:55
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 26, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 26, 2018

Build : SUCCESS

Build number : 2909
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7818/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 26, 2018

@mbed-ci
Copy link

mbed-ci commented Aug 26, 2018

@cmonr
Copy link
Contributor

cmonr commented Aug 27, 2018

/morph uvisor-test

@cmonr
Copy link
Contributor

cmonr commented Aug 27, 2018

@ARMmbed/mbed-os-maintainers Since uVisor is being removed in 5.10, and this PR is only targeting 5.10, anyone object to bringing it in even though the PR is not all green?

I've already removed uVisor as a branch chcek, but if the test ran in a PR before it was removed, it'll still show up in the check list.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 27, 2018

I've already removed uVisor as a branch chcek, but if the test ran in a PR before it was removed, it'll still show up in the check list.

We need to remove uvisor trigger from build comment (manual driver if needed for now). And this check, will be fixed.

@cmonr
Copy link
Contributor

cmonr commented Aug 27, 2018

@SeppoTakalo @KariHaapalehto Would y'all mind taking a look at this? It's ready for merge otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants