Skip to content

MIMXRT1050_EVK: Update the I2C driver #7823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2018
Merged

MIMXRT1050_EVK: Update the I2C driver #7823

merged 1 commit into from
Aug 21, 2018
+21 −17

Conversation

mmahadevan108
Copy link
Contributor

Description

  1. Remove the repeated_start flag and code as this is not needed
    for the LPI2C module
  2. Enable the SION bit on the I2C pins
  3. Enable 22K Pullup option of the I2C pins
  4. Update the 0 byte write implementation to ensure the START command gets flushed out of the FIFO

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@mmahadevan108
MIMXRT1050_EVK: Update the I2C driver
64e5eb0 
1. Remove the repeated_start flag and code as this is not needed
   for the LPI2C module
2. Enable the SION bit on the I2C pins
3. Enable 22K Pullup option of the I2C pins
4. Update the 0 byte write implementation to ensure the START
   command gets flushed out of the FIFO

Signed-off-by: Mahesh Mahadevan <[email protected]>
@mmahadevan108
Copy link
Contributor Author

cc @0xc0170 @cmonr

cmonr
cmonr approved these changes Aug 17, 2018
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, but is this removing repeated start support?

@cmonr
Copy link
Contributor

cmonr commented Aug 17, 2018

Nvm on the comment question. Commit message says it all!

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 17, 2018

Build : SUCCESS

Build number : 2833
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7823/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 18, 2018

Exporter Build : SUCCESS

Build number : 2463
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7823/

@mbed-ci
Copy link

mbed-ci commented Aug 18, 2018

Test : SUCCESS

Build number : 2584
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7823/2584

@NirSonnenschein
Copy link
Contributor

/morph uvisor-test

@cmonr cmonr merged commit 4b5c6c8 into ARMmbed:master Aug 21, 2018
@mmahadevan108 mmahadevan108 deleted the MIMXRT1050_Fix_I2C branch August 21, 2018 15:26
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Merge pull request ARMmbed#7823 from codeauroraforum/MIMXRT1050_Fix_I2C
7c1bde9 
MIMXRT1050_EVK: Update the I2C driver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.9.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mmahadevan108 @cmonr @mbed-ci @NirSonnenschein @0xc0170