-
Notifications
You must be signed in to change notification settings - Fork 3k
Silicon Labs QSPI HAL implementation #7825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can be redirected to master once #7783 lands. |
@stevew817 Did you run |
@maciejbocianski Yes, I did. It passed all tests (43 of them). |
@OPpuolitaival @ARMmbed/mbed-os-test How can jenkins-ci/cloud_client_smoke_test be restarted? |
fcf2c1e
to
58b14ac
Compare
@maciejbocianski Can you formally approve this PR if you're happy with it? |
@stevew817 |
@maciejbocianski It looks like it doesn't need a rebase this time around. /morph build |
Build : FAILUREBuild number : 2902 |
@stevew817 Looks like I spoke too soon, but on the plus side, the fixes look simple. |
@stevew817 pin names should be changed to |
* For EFM32GG11, since that is the only Silicon Labs target with QSPI per today * Verified working using the on-board flash and tests-mbed_hal-qspi
The code is written such that access to the data input/output happens word-by-word, and that means unaligned access is fine (though with a performance loss) on Cortex-M3/M4 devices.
QSPI standard pin names were changed after the QSPI feature PR.
58b14ac
to
55c6dad
Compare
@cmonr @0xc0170 Rebased and updated pinnames, should now be according to spec. @maciejbocianski Feedback post-mortem: It would've been nice to only have one pull request to have to look at when implementing a new feature PR. What was the reason for adding a change PR when the original feature PR wasn't even merged yet? |
/morph build |
Build : SUCCESSBuild number : 2919 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2538 |
Test : SUCCESSBuild number : 2668 |
@stevew817 you are right this should go this way, (the reason was to busy schedule) |
Description
Implemented the QSPI HAL on EFM32GG11, since that is our target which has QSPI available today. The port was verified working on the STK3701 and its on-board QSPI flash, using the supplied hal-qspi test.
Pull request type