-
Notifications
You must be signed in to change notification settings - Fork 3k
WISE_1570 greentea tests #7840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WISE_1570 greentea tests #7840
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks fine to me.
Fixes looks straightforward but at least one there required implementation change (file features/cellular/framework/AT/AT_CellularNetwork.cpp) and does not contain any information how is it fixing it - I would say it should "how it is fixed" at least one sentence there in the commit message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mirelachirica Please update the commit message as Nir suggested |
cacde2b
to
9ef2d0d
Compare
I made a separate commit and also limited the original change to LTE mode only, because only in that mode the last active context shouldnt be deactivated. |
/morph build |
Build : SUCCESSBuild number : 2864 Triggering tests/morph test |
/morph mbed2-build |
Exporter Build : FAILUREBuild number : 2494 |
Test : SUCCESSBuild number : 2629 |
/morph export-build |
Exporter Build : SUCCESSBuild number : 2506 |
Based on top of changes added for 5.10 only and already present in 5.10 |
Description
Fixing greentea tests to work with WISE_1570 modem:
https://jira.arm.com/browse/IOTCELL-1142
Pull request type