Skip to content

WISE_1570 greentea tests #7840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 24, 2018

Conversation

mirelachirica
Copy link
Contributor

Description

Fixing greentea tests to work with WISE_1570 modem:
https://jira.arm.com/browse/IOTCELL-1142

Pull request type

[ x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks fine to me.

Fixes looks straightforward but at least one there required implementation change (file features/cellular/framework/AT/AT_CellularNetwork.cpp) and does not contain any information how is it fixing it - I would say it should "how it is fixed" at least one sentence there in the commit message

@0xc0170 0xc0170 requested a review from a team August 21, 2018 11:37
Copy link

@AnttiKauppila AnttiKauppila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AnttiKauppila
Copy link

@mirelachirica Please update the commit message as Nir suggested

@mirelachirica mirelachirica force-pushed the wise_1570_greentea_tests branch from cacde2b to 9ef2d0d Compare August 22, 2018 11:42
@mirelachirica
Copy link
Contributor Author

I made a separate commit and also limited the original change to LTE mode only, because only in that mode the last active context shouldnt be deactivated.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 22, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 22, 2018

Build : SUCCESS

Build number : 2864
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7840/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 22, 2018

/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 22, 2018

@mbed-ci
Copy link

mbed-ci commented Aug 23, 2018

@cmonr
Copy link
Contributor

cmonr commented Aug 23, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Aug 23, 2018

@adbridge
Copy link
Contributor

adbridge commented Sep 7, 2018

Based on top of changes added for 5.10 only and already present in 5.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants