Skip to content

MIMXRT1050: Fix I2C Byte transfer functions #7843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2018
Merged

MIMXRT1050: Fix I2C Byte transfer functions #7843

merged 1 commit into from
Aug 23, 2018

Conversation

mmahadevan108
Copy link
Contributor

Description

  1. Added a flag to issue START command
  2. Do not send START command inside i2c_start function as the LPI2C hardware will issue a STOP on reception of a NACK
  3. Remove the i2c_address global variable, this is not required

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@mmahadevan108
MIMXRT1050: Fix I2C Byte transfer functions
f71004c 
1. Added a flag to issue START command
2. Do not send START command inside i2c_start function as
   the LPI2C hardware will issue a STOP on reception
   of a NACK
3. Remove the i2c_address global variable, this is not
   required

Signed-off-by: Mahesh Mahadevan <[email protected]>
@mmahadevan108
Copy link
Contributor Author

cc @0xc0170 @cmonr

@cmonr cmonr requested review from cmonr and 0xc0170 August 22, 2018 01:39
cmonr
cmonr reviewed Aug 22, 2018
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a question.

targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_IMX/i2c_api.c
kLPI2C_MasterDataMatchFlag);

/* Turn off auto-stop option. */
base->MCFGR1 &= ~LPI2C_MCFGR1_AUTOSTOP_MASK;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ever turned on again, or is it simply not needed anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not needed.

@cmonr
Copy link
Contributor

cmonr commented Aug 22, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 22, 2018

Build : SUCCESS

Build number : 2859
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7843/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 22, 2018

Exporter Build : SUCCESS

Build number : 2489
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7843/

@mbed-ci
Copy link

mbed-ci commented Aug 23, 2018

Test : SUCCESS

Build number : 2621
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7843/2621

@cmonr cmonr merged commit cb8d09a into ARMmbed:master Aug 23, 2018
@mmahadevan108 mmahadevan108 deleted the MXRT_Fix_I2C_Byte_Transfer branch August 24, 2018 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr left review comments

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.9.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmahadevan108 @cmonr @mbed-ci @0xc0170