-
Notifications
You must be signed in to change notification settings - Fork 3k
Message ID in CAN constructor needs to be unsigned #7848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…essary implicit casting
/morph build |
Build : SUCCESSBuild number : 2857 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2487 |
Test : FAILUREBuild number : 2619 |
/morph test |
1 similar comment
/morph test |
Test : SUCCESSBuild number : 2660 |
@cmonr CI passed but only one review (yours), does this count as ready to merge? |
@NirSonnenschein It's a small bug update, so it should be fine. |
Change data type of MessageID in CAN constructor to unsigned from int to avoid unnecessary implicit conversion from int to unsigned.
Issue: #7444