Skip to content

Message ID in CAN constructor needs to be unsigned #7848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2018

Conversation

aashishc1988
Copy link
Contributor

@aashishc1988 aashishc1988 commented Aug 21, 2018

Change data type of MessageID in CAN constructor to unsigned from int to avoid unnecessary implicit conversion from int to unsigned.

Issue: #7444

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@cmonr
Copy link
Contributor

cmonr commented Aug 22, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 22, 2018

Build : SUCCESS

Build number : 2857
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7848/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 22, 2018

@mbed-ci
Copy link

mbed-ci commented Aug 23, 2018

@NirSonnenschein
Copy link
Contributor

/morph test

1 similar comment
@cmonr
Copy link
Contributor

cmonr commented Aug 27, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Aug 27, 2018

@NirSonnenschein
Copy link
Contributor

@cmonr CI passed but only one review (yours), does this count as ready to merge?

@cmonr
Copy link
Contributor

cmonr commented Aug 27, 2018

@NirSonnenschein It's a small bug update, so it should be fine.
BUT since the constructor changes, it should go to the feature release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants