Skip to content

Realtek: fix gpio is connected #7856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2018
Merged

Realtek: fix gpio is connected #7856

merged 1 commit into from
Sep 18, 2018

Conversation

fredlee12001
Copy link
Contributor

Description

Met linking issue when try to compile the mbed-cloud-client-example for REALTEK_RTL8195AM platform using ARM toolchain.

mbed compile -t ARM -m REALTEK_RTL8195AM
.....
.....
Link: mbed-cloud-client-example
Error: L6218E: Undefined symbol gpio_is_connected (referred from ../BUILD/REALTEK_RTL8195AM/ARM/storage-selector/dataflash-driver/DataFlashBlockDevice.o).
Finished: 0 information, 0 warning and 1 error messages.
[ERROR] Error: L6218E: Undefined symbol gpio_is_connected (referred from ../BUILD/REALTEK_RTL8195AM/ARM/storage-selector/dataflash-driver/DataFlashBlockDevice.o).
Finished: 0 information, 0 warning and 1 error messages.

[mbed] ERROR: "c:\python27\python.exe" returned error code 1.

Pull request type

[X ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@0xc0170 0xc0170 requested a review from a team August 22, 2018 09:14
@0xc0170 0xc0170 changed the title Fix Link issue when compile mbed-cloud-client-example. Realtek: fix gpio is connected Aug 22, 2018
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 22, 2018

Merge pull request #1 from ARMmbed/master …

Can you rebase this instead please? (to remove this merge commit)

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, just needs a rebase

@fredlee12001
Copy link
Contributor Author

Rebase to master instead of create PR.

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed the style is different (the rest of file has it fine)

int gpio_is_connected(const gpio_t *obj)
{
}

{ on the new line.

Thanks for the rebase, this shall be ready for CI once fixed

@fredlee12001
Copy link
Contributor Author

Changed and Keep same coding style with others.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 17, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 17, 2018

Build : SUCCESS

Build number : 3085
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7856/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 17, 2018

@mbed-ci
Copy link

mbed-ci commented Sep 17, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 18, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Sep 18, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 18, 2018

@studavekar Please review the latest test result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants