-
Notifications
You must be signed in to change notification settings - Fork 3k
Realtek: fix gpio is connected #7856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can you rebase this instead please? (to remove this merge commit) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, just needs a rebase
Rebase to master instead of create PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed the style is different (the rest of file has it fine)
int gpio_is_connected(const gpio_t *obj)
{
}
{
on the new line.
Thanks for the rebase, this shall be ready for CI once fixed
Changed and Keep same coding style with others. |
/morph build |
Build : SUCCESSBuild number : 3085 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2695 |
Test : FAILUREBuild number : 2874 |
/morph test |
Test : SUCCESSBuild number : 2878 |
@studavekar Please review the latest test result. |
Description
Met linking issue when try to compile the mbed-cloud-client-example for REALTEK_RTL8195AM platform using ARM toolchain.
mbed compile -t ARM -m REALTEK_RTL8195AM
.....
.....
Link: mbed-cloud-client-example
Error: L6218E: Undefined symbol gpio_is_connected (referred from ../BUILD/REALTEK_RTL8195AM/ARM/storage-selector/dataflash-driver/DataFlashBlockDevice.o).
Finished: 0 information, 0 warning and 1 error messages.
[ERROR] Error: L6218E: Undefined symbol gpio_is_connected (referred from ../BUILD/REALTEK_RTL8195AM/ARM/storage-selector/dataflash-driver/DataFlashBlockDevice.o).
Finished: 0 information, 0 warning and 1 error messages.
[mbed] ERROR: "c:\python27\python.exe" returned error code 1.
Pull request type