Skip to content

Cellular: Make AT_CellularStack socket array multi-thread safe #7857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2018

Conversation

AriParkkila
Copy link

Description

The socket array _sockets was not multi-thread safe. That could be a problem if two threads try to open socket at the same.

In socket_close() was delete socket called erroneously before calling socket_close_impl, that may still use that socket.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@AriParkkila
Copy link
Author

@mirelachirica please review

@0xc0170 0xc0170 requested a review from a team August 22, 2018 10:56
Copy link
Contributor

@jarvte jarvte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Declaration of _socket_mutex is ifdef'd but not it's usage. Remove #ifdef or add them also where it's used.

@AriParkkila
Copy link
Author

@jarvte please review

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 27, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 27, 2018

Build : SUCCESS

Build number : 2916
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7857/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 27, 2018

@mbed-ci
Copy link

mbed-ci commented Aug 27, 2018

@cmonr cmonr merged commit 686b779 into ARMmbed:master Aug 27, 2018
@AriParkkila AriParkkila deleted the cell-stack-mt branch September 10, 2018 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants