-
Notifications
You must be signed in to change notification settings - Fork 3k
Cellular: Make AT_CellularStack socket array multi-thread safe #7857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@mirelachirica please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Declaration of _socket_mutex is ifdef'd but not it's usage. Remove #ifdef or add them also where it's used.
6ecfcd0
to
4b223b6
Compare
@jarvte please review |
/morph build |
Build : SUCCESSBuild number : 2916 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2535 |
Test : SUCCESSBuild number : 2665 |
Description
The socket array
_sockets
was not multi-thread safe. That could be a problem if two threads try to open socket at the same.In socket_close() was
delete socket
called erroneously before callingsocket_close_impl
, that may still use that socket.Pull request type