Skip to content

Cellular: Allow cellular modules to override network registration mode #7860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2018

Conversation

AriParkkila
Copy link

Description

Cellular network registration is by default in mode 2, that is defined in 3GPP TS 27.007 as [,<[lac>,]<[ci>],[],[]]

That value must be configurable because some modems support only certain modes on specific technologies and also in some cases it's required to support extended modes, such as requested in the issue #7496

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@AriParkkila
Copy link
Author

@mirelachirica please review

@0xc0170 0xc0170 requested a review from a team August 22, 2018 13:23
}
return true;
return 2;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"#define" for numbers 0 and 2 would help reading for people unfamiliar with Cellular

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not use define because the value comes from 3GPP spec and you need to read that in any case to understand what you are doing. Also when the mode is a define and a modem specific porting requires a new mode they also need to make a define also in the generic codes at AT layer. But I can change that if you think its more clear with define?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to echo the sentiment of no magic numbers where possible, even if they are hardcoded in some spec.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#define works in this case as a hint, it might be the case that developer has read the spec and with this hint s/he finds the context immediately without reading the spec again. Let's define those.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnttiKauppila please review

@cmonr
Copy link
Contributor

cmonr commented Aug 27, 2018

/morph build

@cmonr cmonr added the risk: G label Aug 27, 2018
@mbed-ci
Copy link

mbed-ci commented Aug 27, 2018

Build : SUCCESS

Build number : 2927
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7860/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 27, 2018

@mbed-ci
Copy link

mbed-ci commented Aug 28, 2018

@0xc0170 0xc0170 merged commit 9e012c3 into ARMmbed:master Aug 28, 2018
@cmonr cmonr removed the risk: G label Sep 2, 2018
@AriParkkila AriParkkila deleted the cell-reg-mode branch September 10, 2018 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants