Skip to content

Tools: Modified version mismatch msg to be warning instead of error #7876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2018
Merged

Tools: Modified version mismatch msg to be warning instead of error #7876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/toolchains/arm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ def version_check(self):
"file": "",
"line": "",
"col": "",
"severity": "ERROR",
"severity": "WARNING",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this WARNING and other two just "Warning" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xc0170 Which other two are you referring to?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other toolchains, but I can see this one used previously capital letters

})

def _get_toolchain_labels(self):
Expand Down
2 changes: 1 addition & 1 deletion tools/toolchains/gcc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ def version_check(self):
"file": "",
"line": "",
"col": "",
"severity": "ERROR",
"severity": "Warning",
})

def is_not_supported_error(self, output):
Expand Down
2 changes: 1 addition & 1 deletion tools/toolchains/iar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ def version_check(self):
"file": "",
"line": "",
"col": "",
"severity": "ERROR",
"severity": "Warning",
})


Expand Down