netsocket: Fix compiler warning #7883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

cmonr merged 1 commit into ARMmbed:master from juhaylinen:fix-netsocket-warning

Sep 18, 2018

Contributor

juhaylinen commented Aug 24, 2018

Description

Fixes below warning from GCC_ARM compiler:
[Warning] InternetSocket.h@237,10: 'InternetSocket::_factory_allocated' will be initialized after [-Wreorder]
[Warning] InternetSocket.h@236,23: 'volatile unsigned int InternetSocket::_pending' [-Wreorder]
[Warning] InternetSocket.cpp@22,1: when initialized here [-Wreorder]

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change


          netsocket: Fix compiler warning

b8b39ac

[Warning] InternetSocket.h@237,10: 'InternetSocket::_factory_allocated' will be initialized after [-Wreorder]
[Warning] InternetSocket.h@236,23:   'volatile unsigned int InternetSocket::_pending' [-Wreorder]
[Warning] InternetSocket.cpp@22,1:   when initialized here [-Wreorder]

0xc0170 requested a review from a team

August 24, 2018 12:16

0xc0170 added the needs: review label

kjbracey approved these changes

View reviewed changes

0xc0170 approved these changes

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels

SeppoTakalo approved these changes

View reviewed changes

Contributor

0xc0170 commented Aug 27, 2018

/morph build

mbed-ci commented Aug 27, 2018

Build : SUCCESS

Build number : 2922
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7883/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci commented Aug 27, 2018

Exporter Build : SUCCESS

Build number : 2542
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7883/

mbed-ci commented Aug 28, 2018

Test : FAILURE

Build number : 2673
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7883/2673

Contributor

cmonr commented Aug 28, 2018

Huh. I don't think the failure is related to the PR. @juhaylinen Could you confirm?

Contributor Author

juhaylinen commented Aug 28, 2018

@cmonr Looks like random fail. Please restart the tests.

Contributor

0xc0170 commented Aug 28, 2018

/morph test

juhaylinen mentioned this pull request

Reorder members to resolve build warning #7906

Closed

mbed-ci commented Aug 28, 2018

Test : FAILURE

Build number : 2687
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7883/2687

Contributor Author

juhaylinen commented Sep 7, 2018

Greentea sync failure. Please restart.

Contributor

0xc0170 commented Sep 7, 2018

Greentea sync failure. Please restart.

Will do once rc2 PR are completed

Contributor

adbridge commented Sep 10, 2018

/morph build

mbed-ci commented Sep 10, 2018

Build : SUCCESS

Build number : 3044
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7883/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

mbed-ci commented Sep 10, 2018

Exporter Build : SUCCESS

Build number : 2660
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7883/

Contributor

cmonr commented Sep 11, 2018

Test CI needs to be restarted. Will restart aftetr 5.10-rc2 is generated.

mbed-ci commented Sep 11, 2018

Test : FAILURE

Build number : 2820
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7883/2820

Contributor

0xc0170 commented Sep 18, 2018

/morph test

mbed-ci commented Sep 18, 2018

Test : SUCCESS

Build number : 2879
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7883/2879

0xc0170 added ready for merge release-version: 5.10.1 needs: CI and removed needs: CI labels

0xc0170 removed the ready for merge label

cmonr merged commit c356f1f into ARMmbed:master

cmonr removed the needs: CI label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-version: 5.10.1