Skip to content

Remove unused cmsis includes. #7891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2018
Merged

Remove unused cmsis includes. #7891

merged 1 commit into from
Aug 28, 2018

Conversation

tkem
Copy link
Contributor

@tkem tkem commented Aug 25, 2018

Description

Remove unused "cmsis.h" includes from CAN and TimerEvent drivers.
AFAICS those files do not use any CMSIS functionality, and I guess code in "drivers" shouldn't use CMSIS directly, anyway.
Since this is not really a "Fix" (nothing's broken, actually), I'll go with "Refactor" as Pull request type (maybe you want to add "Cleanup" to that list).

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@0xc0170 0xc0170 requested a review from a team August 27, 2018 07:57
@cmonr cmonr requested a review from c1728p9 August 27, 2018 14:16
@cmonr
Copy link
Contributor

cmonr commented Aug 27, 2018

@c1728p9 Could you take a quick look at this?

@cmonr
Copy link
Contributor

cmonr commented Aug 27, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 27, 2018

Build : SUCCESS

Build number : 2931
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7891/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 27, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 28, 2018

@OPpuolitaival @studavekar Another multiple defined symbols (cleanup problem?)

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Aug 28, 2018

@mbed-ci
Copy link

mbed-ci commented Aug 28, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 28, 2018

/morph mbed2-build

@cmonr cmonr merged commit 3f5cd54 into ARMmbed:master Aug 28, 2018
@tkem tkem deleted the fix/remove-unnnecessary-includes branch August 28, 2018 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants