Skip to content

Lora: Improve description of callback methods #7893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2018
Merged

Lora: Improve description of callback methods #7893

merged 2 commits into from
Sep 4, 2018

Conversation

kivaisan
Copy link
Contributor

@kivaisan kivaisan commented Aug 27, 2018 •
edited
Loading

Description

Users often use "show declaration" (or similar) in their IDE to see descriptions of callback
methods so the function descriptions should be placed close to function declaration itself.

Pull request type

[X] Documentation
[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

Lora: Improve description of callback methods
fdff9f0 
Users often use "show declaration" (or similar) in their IDE to see descriptions of callback
methods so the function descriptions should be placed close to function declaration itself.
@0xc0170 0xc0170 requested a review from AnotherButler August 27, 2018 09:46
@kivaisan
Copy link
Contributor Author

@hasnainvirk @AnotherButler please review.

@0xc0170 0xc0170 requested a review from a team August 27, 2018 09:46
Copy edit lorawan_types.h
e4c4e7c 
Copy edit for minor grammar nits and consistent tense across docs.
@AnttiKauppila
Copy link

This is targeted to 5.10.0-rc2

@adbridge
Copy link
Contributor

adbridge commented Sep 3, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 3, 2018

Build : SUCCESS

Build number : 2998
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7893/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 4, 2018

Exporter Build : SUCCESS

Build number : 2609
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7893/

@mbed-ci
Copy link

mbed-ci commented Sep 4, 2018

Test : FAILURE

Build number : 2762
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7893/2762

@cmonr
Copy link
Contributor

cmonr commented Sep 4, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Sep 4, 2018

Test : FAILURE

Build number : 2765
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7893/2765

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 4, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Sep 4, 2018

Test : SUCCESS

Build number : 2767
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7893/2767

@cmonr cmonr merged commit 6165386 into ARMmbed:master Sep 4, 2018
@0xc0170 0xc0170 removed the needs: CI label Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@hasnainvirk hasnainvirk hasnainvirk approved these changes

@AnotherButler AnotherButler AnotherButler approved these changes

Assignees
No one assigned
Labels
release-version: 5.10.0-rc2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@kivaisan @AnttiKauppila @adbridge @mbed-ci @cmonr @0xc0170 @hasnainvirk @AnotherButler