-
Notifications
You must be signed in to change notification settings - Fork 3k
Update mbed-coap to version 4.6.2 #7907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Do not clear block2 in subsequent block request. When sending a request with block2 option, eg. indicating need for response to be blockwised, copy the block2 option from the sent_blockwise list item so that the block2 option will be added to all requests. This fixes an issue where previously the block2 was only sent for the first blockwise request and not for the subsequent ones, including the last request. This made the response not follow the request block2 option.
94b95da
to
7ae00ee
Compare
@kuggenhoffen, @yogpan01, please review. |
We will start CI once the queue decreases slightly |
/morph build |
Build : SUCCESSBuild number : 2951 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2567 |
Reshuffling the Integration Test queue. Will restart shortly. |
Test : FAILUREBuild number : 2699 |
/morph test |
1 similar comment
/morph test |
Test : FAILUREBuild number : 2747 |
/morph test |
Test : SUCCESSBuild number : 2749 |
Description
Do not clear block2 in subsequent block request.
When sending a request with block2 option, eg. indicating need
for response to be blockwised, copy the block2 option from the
sent_blockwise list item so that the block2 option will be added
to all requests. This fixes an issue where previously the block2
was only sent for the first blockwise request and not for the
subsequent ones, including the last request. This made the response
not follow the request block2 option.
Pull request type