Skip to content

Update mbed-coap to version 4.6.2 #7907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2018

Conversation

anttiylitokola
Copy link
Contributor

Description

Do not clear block2 in subsequent block request.

When sending a request with block2 option, eg. indicating need
for response to be blockwised, copy the block2 option from the
sent_blockwise list item so that the block2 option will be added
to all requests. This fixes an issue where previously the block2
was only sent for the first blockwise request and not for the
subsequent ones, including the last request. This made the response
not follow the request block2 option.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@anttiylitokola anttiylitokola changed the title Updata mbed-coap to version 4.6.2 Update mbed-coap to version 4.6.2 Aug 28, 2018
Do not clear block2 in subsequent block request.

When sending a request with block2 option, eg. indicating need
for response to be blockwised, copy the block2 option from the
sent_blockwise list item so that the block2 option will be added
to all requests. This fixes an issue where previously the block2
was only sent for the first blockwise request and not for the
subsequent ones, including the last request. This made the response
not follow the request block2 option.
@anttiylitokola
Copy link
Contributor Author

@kuggenhoffen, @yogpan01, please review.

@yogpan01
Copy link
Contributor

Approved. @0xc0170 @cmonr please take this PR in for mbed-os-5.10 release.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 28, 2018

We will start CI once the queue decreases slightly

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 29, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 29, 2018

Build : SUCCESS

Build number : 2951
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7907/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 29, 2018

@cmonr
Copy link
Contributor

cmonr commented Aug 29, 2018

Reshuffling the Integration Test queue. Will restart shortly.

@mbed-ci
Copy link

mbed-ci commented Aug 29, 2018

@NirSonnenschein
Copy link
Contributor

/morph test

1 similar comment
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 2, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Sep 2, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 2, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Sep 2, 2018

@cmonr cmonr merged commit e7c166e into ARMmbed:master Sep 2, 2018
@0xc0170 0xc0170 removed the needs: CI label Sep 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants